Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pack: broken on Windows, cannot find GOCHAR in 'go env' output #7362

Closed
bradfitz opened this issue Feb 19, 2014 · 9 comments
Closed

cmd/pack: broken on Windows, cannot find GOCHAR in 'go env' output #7362

bradfitz opened this issue Feb 19, 2014 · 9 comments
Labels
FrozenDueToAge
Milestone
Go1.3

Comments

@bradfitz
Copy link
Contributor 

cmd/pack is now broken on Windows:

--- FAIL: TestHello (0.02 seconds)
    pack_test.go:198: cannot find GOCHAR in 'go env' output
FAIL
FAIL    cmd/pack    0.063s

e.g. http://build.golang.org/log/500ac7db7b9db0643d2a594d8ca4d8bac32facdc

as of
https://code.google.com/p/go/source/detail?r=48a4a9afb88b894eb2510469587f1e832185cea6

Probably can't find go.
@robpike
Copy link
Contributor

robpike commented Feb 19, 2014

Comment 1:

This issue was updated by revision 8ac4999.

LGTM=bradfitz
R=rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/66070044

@alexbrainman
Copy link
Member

Comment 2:

I will investigate this, unless you already know what the problem is.
Alex

@bradfitz
Copy link
Contributor Author

Comment 3:

Should already be fixed by https://code.google.com/p/go/source/detail?r=81379255e86

Owner changed to @robpike.

Status changed to Started.

@alexbrainman
Copy link
Member

Comment 4:

Still broken. I will look into it.
Alex

@robpike
Copy link
Contributor

robpike commented Feb 19, 2014

Comment 5:

Looks like a missing .exe?

@alexbrainman
Copy link
Member

Comment 6:

Perhaps. I will investigate this. See what works.
Alex

@alexbrainman
Copy link
Member

Comment 7:

https://golang.org/cl/66250043/

@alexbrainman
Copy link
Member

Comment 8:

This issue was closed by revision 0d11cd1.

Status changed to Fixed.

@alexbrainman
Copy link
Member

Comment 9:

This issue was updated by revision df8ec65.

Fixes issue #7377
Fixes issue #7570
LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://golang.org/cl/83020043

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned robpike Jun 23, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
5 participants
@bradfitz @rsc @robpike @gopherbot @alexbrainman