code review 66070044: cmd/pack: dump output of command of "go env" command in test

cmd/pack: dump output of command of "go env" command in test
Get more information to help understand build failure on Plan 9.
Also Windows.
(TestHello is failing because GOCHAR does not appear in output.
What does?)

Update issue 7362

[r, 2014-02-19 22:55:04]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-02-19 22:55:41]

LGTM



On Wed, Feb 19, 2014 at 2:55 PM, <r@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/pack: dump output of command of "go env" command in test
> Get more information to help understand build failure on Plan 9.
> (TestHello is failing because GOCHAR does not appear in output.
> What does?)
>
> Please review this at https://codereview.appspot.com/66070044/
>
> Affected files (+1, -1 lines):
>   M src/cmd/pack/pack_test.go
>
>
> Index: src/cmd/pack/pack_test.go
> ===================================================================
> --- a/src/cmd/pack/pack_test.go
> +++ b/src/cmd/pack/pack_test.go
> @@ -195,7 +195,7 @@
>         out := run("go", "env")
>         i := strings.Index(out, "GOCHAR=\"")
>         if i < 0 {
> -               t.Fatal("cannot find GOCHAR in 'go env' output")
> +               t.Fatal("cannot find GOCHAR in 'go env' output:\n", out)
>         }
>         char := out[i+8 : i+9]
>         run("go", "build", "cmd/pack") // writes pack binary to dir
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[bradfitz, 2014-02-19 22:56:05]

Update Issue https://code.google.com/p/go/issues/detail?id=7362 mabye


On Wed, Feb 19, 2014 at 2:55 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> LGTM
>
>
>
> On Wed, Feb 19, 2014 at 2:55 PM, <r@golang.org> wrote:
>
>> Reviewers: rsc,
>>
>> Message:
>> Hello rsc (cc: golang-codereviews@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go
>>
>>
>> Description:
>> cmd/pack: dump output of command of "go env" command in test
>> Get more information to help understand build failure on Plan 9.
>> (TestHello is failing because GOCHAR does not appear in output.
>> What does?)
>>
>> Please review this at https://codereview.appspot.com/66070044/
>>
>> Affected files (+1, -1 lines):
>>   M src/cmd/pack/pack_test.go
>>
>>
>> Index: src/cmd/pack/pack_test.go
>> ===================================================================
>> --- a/src/cmd/pack/pack_test.go
>> +++ b/src/cmd/pack/pack_test.go
>> @@ -195,7 +195,7 @@
>>         out := run("go", "env")
>>         i := strings.Index(out, "GOCHAR=\"")
>>         if i < 0 {
>> -               t.Fatal("cannot find GOCHAR in 'go env' output")
>> +               t.Fatal("cannot find GOCHAR in 'go env' output:\n", out)
>>         }
>>         char := out[i+8 : i+9]
>>         run("go", "build", "cmd/pack") // writes pack binary to dir
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>

[r, 2014-02-19 23:00:39]

*** Submitted as https://code.google.com/p/go/source/detail?r=f28dc1ba53cf ***

cmd/pack: dump output of command of "go env" command in test
Get more information to help understand build failure on Plan 9.
Also Windows.
(TestHello is failing because GOCHAR does not appear in output.
What does?)

Update issue 7362

LGTM=bradfitz
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/66070044

[gobot, 2014-02-19 23:42:40]

This CL appears to have broken the linux-amd64-race builder.