code review 66250043: cmd/pack: provide executable name in TestHello

cmd/pack: provide executable name in TestHello

otherwise go build command adds .exe suffix

Fixes issue 7362

[brainman, 2014-02-20 00:21:02]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-02-20 00:23:18]

LGTM

[brainman, 2014-02-20 00:29:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=1c88090bebc6 ***

cmd/pack: provide executable name in TestHello

otherwise go build command adds .exe suffix

Fixes issue 7362

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/66250043

[rsc, 2014-02-20 01:12:26]

okay but if i write pack.exe i can't execute ./pack ? that seems like a bug.

[bradfitz, 2014-02-20 01:14:37]

LookPath will find it with a PATHEXT extension, but if you have a slash in
your exec.Command() binary path, LookPath is not used.

Maybe that should be different on Windows, where LookPath does more.



On Wed, Feb 19, 2014 at 5:12 PM, <rsc@golang.org> wrote:

> okay but if i write pack.exe i can't execute ./pack ? that seems like a
> bug.
>
>
> https://codereview.appspot.com/66250043/
>

[brainman, 2014-02-20 01:27:19]

On 2014/02/20 01:12:26, rsc wrote:
> okay but if i write pack.exe i can't execute ./pack ? that seems like a bug.

We use CreateProcess function to execute programs

http://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx

this is what it says about lpApplicationName (executable name) parameter:

The string can specify the full path and file name of the module to execute or
it can specify a partial name. In the case of a partial name, the function uses
the current drive and current directory to complete the specification. The
function will not use the search path. This parameter must include the file name
extension; no default extension is assumed.

<<<

The last bit makes our current behaviour reasonable. But, I admit, I have some
questions at the back of my mind. Can you explain your concern in details?

Alex

[brainman, 2014-02-20 01:34:18]

Maybe you are right. Maybe we should treat both ".\pack" and "./pack" as we
treat "pack"?

Alex

[bradfitz, 2014-02-20 01:45:30]

Who is "you"?  You didn't quote any part of a prior email, and your email
doesn't contain a In-Reply-To header (not that gmail would respect it
anyway, but then at least I could figure out context by hand).



On Wed, Feb 19, 2014 at 5:34 PM, <alex.brainman@gmail.com> wrote:

> Maybe you are right. Maybe we should treat both ".\pack" and "./pack" as
> we treat "pack"?
>
> Alex
>
> https://codereview.appspot.com/66250043/
>

[brainman, 2014-02-20 01:49:12]

On 2014/02/20 01:45:30, bradfitz wrote:
> Who is "you"?  You didn't quote any part of a prior email, and your email
> doesn't contain a In-Reply-To header (not that gmail would respect it
> anyway, but then at least I could figure out context by hand).
> 

Sorry, I meant to say that Russ might be right. Perhaps we have a problem here.
I will think about this.

Alex

[brainman, 2014-02-21 06:35:19]

I have created an issue https://code.google.com/p/go/issues/detail?id=7377. I
will try to fix it as soon as I can.

Alex