Skip to content

bufio: optimize bufio.Reader.WriteTo() and bufio.Writer.ReadFrom() #6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Sep 12, 2013 · 15 comments
Closed

bufio: optimize bufio.Reader.WriteTo() and bufio.Writer.ReadFrom() #6373

gopherbot opened this issue Sep 12, 2013 · 15 comments
Labels
FrozenDueToAge Performance
Milestone
Unplanned

Comments

@gopherbot
Copy link
Contributor

by valyala:

Current implementations of bufio.Reader.WriteTo() and bufio.Writer.ReadFrom() can be
optimized further for common cases such as copying big files to / from network
connections.

See the following topic for details -
https://groups.google.com/d/msg/golang-nuts/oYYggbLntVE/DMsqEyIU-yIJ
@robpike
Copy link
Contributor

robpike commented Sep 13, 2013

Comment 1:

Labels changed: added priority-later, performance, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 2:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added repo-main.

@gopherbot
Copy link
Contributor Author

Comment 5 by pongad:

Working on it!

@gopherbot
Copy link
Contributor Author

Comment 6 by pongad:

https://golang.org/cl/53560043/

@gopherbot
Copy link
Contributor Author

Comment 7 by valyala:

Is there any progress on this issue?

@bradfitz
Copy link
Contributor

Comment 8:

This issue was updated by revision b00e477.

LGTM=iant, gri
R=golang-codereviews, iant, gri
CC=golang-codereviews
https://golang.org/cl/69220046

@gopherbot
Copy link
Contributor Author

Comment 9 by pongad:

I would like to continue working on this. Unless someone would like to work on issue
7744 and tackle this in one go?

@bradfitz
Copy link
Contributor

Comment 10:

Go ahead and do this. Now's the time.
I am skeptical on issue #7744.

@gopherbot
Copy link
Contributor Author

Comment 11 by pongad:

https://golang.org/cl/103710044/
The benchmark does not look encouraging. Please see my first comment on the CL for more
detail.

@gopherbot
Copy link
Contributor Author

Comment 12:

CL https://golang.org/cl/103710044 mentions this issue.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@odeke-em
Copy link
Member

odeke-em commented Jun 6, 2020

@vancluever perhaps you might be interested in this issue, if you get time and are bored :)

@vancluever
Copy link
Contributor

I'll definitely keep it in mind! :)

@odeke-em
Copy link
Member

This issue got implemented with CLs https://golang.org/cl/69220046 aka commit b00e477 for .WriteTo which falls back to using the target's .ReadFrom method and then https://golang.org/cl/6548047 aka commit e289a2b for the target's .WriteTo method thus we can close this legacy issue. Please reopen if necessary.

@golang golang locked and limited conversation to collaborators Mar 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Performance
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
6 participants
@bradfitz @rsc @robpike @odeke-em @gopherbot @vancluever