Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 53560043: code review 53560043: bufio: Reader shortcuts to ReadFrom(). Writer shortcuts... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by pongad
Modified:
9 years, 9 months ago
Visibility:
Public.

Description

bufio: Reader shortcuts to ReadFrom(). Writer shortcuts to b.wr.ReadFrom() if first read doesn't fill buffer. Fixes issue 6373.

Patch Set 1 #

Patch Set 2 : diff -r ec4ec27f4756 https://code.google.com/p/go #

Patch Set 3 : diff -r ec4ec27f4756 https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -12 lines) Patch
M src/pkg/bufio/bufio.go View 1 3 chunks +42 lines, -12 lines 1 comment Download

Messages

Total messages: 11
pongad
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 2 months ago (2014-01-17 01:50:38 UTC) #1
bradfitz
I would expect test additions, and/or a benchmark result. On Thu, Jan 16, 2014 at ...
10 years, 2 months ago (2014-01-17 01:56:52 UTC) #2
bradfitz
https://codereview.appspot.com/53560043/diff/40001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/53560043/diff/40001/src/pkg/bufio/bufio.go#newcode616 src/pkg/bufio/bufio.go:616: defer func() { does this need to be a ...
10 years, 2 months ago (2014-01-17 01:58:41 UTC) #3
pongad
On 2014/01/17 01:58:41, bradfitz wrote: > https://codereview.appspot.com/53560043/diff/40001/src/pkg/bufio/bufio.go > File src/pkg/bufio/bufio.go (right): > > https://codereview.appspot.com/53560043/diff/40001/src/pkg/bufio/bufio.go#newcode616 > ...
10 years, 2 months ago (2014-01-17 02:35:15 UTC) #4
dfc
Protip: $GOROOT/misc/benchcmp before.txt after.txt On Fri, Jan 17, 2014 at 1:35 PM, <pongad@gmail.com> wrote: > ...
10 years, 2 months ago (2014-01-17 02:47:31 UTC) #5
pongad
Newbie response: benchmark old ns/op new ns/op delta BenchmarkReaderCopyOptimal 1410 1334 -5.39% BenchmarkReaderCopyUnoptimal 8813 8346 ...
10 years, 2 months ago (2014-01-17 03:01:53 UTC) #6
dfc
Nice work On Fri, Jan 17, 2014 at 2:01 PM, <pongad@gmail.com> wrote: > Newbie response: ...
10 years, 2 months ago (2014-01-17 03:08:06 UTC) #7
pongad
Also implemented with goto instead of defer. Does everyone like goto better? If so, I'll ...
10 years, 2 months ago (2014-01-20 19:33:14 UTC) #8
bradfitz
For lack of activity here, I've sent off the simple part of this as https://codereview.appspot.com/69220046/ ...
10 years, 1 month ago (2014-02-27 07:57:01 UTC) #9
pongad
I'm currently swamped with schoolwork, so I won't be able to get to it in ...
10 years, 1 month ago (2014-02-27 22:51:23 UTC) #10
bradfitz
10 years ago (2014-03-08 00:57:50 UTC) #11
R=close

This missed Go 1.3.  Please re-send the remainder for Go 1.4 in June.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b