Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bufio: could use a clean rewrite (while maintaining the API) #7744

Closed
griesemer opened this issue Apr 9, 2014 · 4 comments
Closed

bufio: could use a clean rewrite (while maintaining the API) #7744

griesemer opened this issue Apr 9, 2014 · 4 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@griesemer
Copy link
Contributor 

Too many people have fiddled with this code by now, and it's somewhat inconsistent
internally and hard to reason about. It could use a clean rewrite.
@bradfitz
Copy link
Contributor

Comment 1:

I'm skeptical about rewriting it.
Doing a cleanup consistency pass is fine, but I wouldn't start afresh. A lot of the work
on bufio has been subtle stuff and performance stuff. Throwing it all out seems risky.
I'd at least like to see a consistency pass before any wholesale rewrite.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/113060043 mentions this issue.

@adg
Copy link
Contributor

adg commented Aug 22, 2014

Comment 3:

Definitely won't happen before the freeze.

Labels changed: added release-none, removed release-go1.4.

@griesemer griesemer self-assigned this Aug 22, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@griesemer
Copy link
Contributor Author

Closed due to age.

@golang golang locked and limited conversation to collaborators Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@bradfitz @rsc @adg @griesemer @gopherbot