Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/api: run api check on builders #6124

Closed
alexbrainman opened this issue Aug 13, 2013 · 10 comments
Closed

cmd/api: run api check on builders #6124

alexbrainman opened this issue Aug 13, 2013 · 10 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.2

Comments

@alexbrainman
Copy link
Member 

all.bat skips cmd/api checks:

...

# Checking API compatibility.
Skipping cmd/api checks; hg codereview extension not available and GO_FORCE_API_CHECK
not set

ALL TESTS PASSED

---
Installed Go for windows/386 in C:\go\root
Installed commands in C:\go\root\bin
*** You need to add C:\go\root\bin to your PATH.

I expect no one has codereview installed on windows, so cmd/api does not run anywhere
(including our builders).

Alex
@rsc
Copy link
Contributor

rsc commented Sep 10, 2013

Comment 1:

Labels changed: added testing.

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 2:

Are the windows builders running the API check? We need to make sure they are before we
cut a release.

Labels changed: added priority-later, go1.2, removed priority-triage, go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 3:

Labels changed: added releaseblocker.

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 5:

This issue was updated by revision 89a6a8f.

TBR=golang-dev
CC=golang-dev
https://golang.org/cl/13632053

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 6:

This issue was updated by revision 6624b70.

TBR=golang-dev
CC=golang-dev
https://golang.org/cl/13632053
»»»
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/13474045

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 7:

We'll know conclusively in a little while, but I'm fairly certain at this point that no
builders are running the api tool. This needs to be fixed.

@rsc
Copy link
Contributor

rsc commented Sep 11, 2013

Comment 8:

This issue was updated by revision cdc5356.

TBR=golang-dev
CC=golang-dev
https://golang.org/cl/13385046

@bradfitz
Copy link
Contributor

Comment 9:

Well, crap.  The linux-amd64 and linux-386 builders have GO_FORCE_API_CHECK set but I
guess the builders are stripping that from the child processes' environment.

Owner changed to @bradfitz.

@bradfitz
Copy link
Contributor

Comment 10:

Sent out https://golang.org/cl/13500046/

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 11:

This issue was closed by revision afda774.

Status changed to Fixed.

@alexbrainman alexbrainman added fixed Testing An issue that has been verified to require only test changes, not just a test failure. labels Sep 22, 2013
@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
4 participants
@bradfitz @rsc @gopherbot @alexbrainman