Issue 13474045: code review 13474045: undo CL 13632053 / dc7bfe0f022d

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13474045: code review 13474045: undo CL 13632053 / dc7bfe0f022d (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

undo CL 13632053 / dc7bfe0f022d It was never going to last. ««« original CL description cmd/api: break the builds There is some question about whether the api tool is running on Windows (see issue 6124), and now I'm starting to question whether it runs on any of the builders, since both darwin/amd64 and linux/amd64 are crashing for me in the api tool due to a recent cgo-related change, and yet the dashboard is happy. If the dashboard is still happy after this CL, we have a problem. Update issue 6124 TBR=golang-dev CC=golang-dev https://codereview.appspot.com/13632053 »»»

Patch Set 1 #

Patch Set 2 : diff -r dc7bfe0f022d https://code.google.com/p/go/ #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	src/cmd/api/goapi.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 8 months ago (2013-09-11 18:35:07 UTC) #1

rsc

10 years, 8 months ago (2013-09-11 18:35:11 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=744fe06687cc ***

undo CL 13632053 / dc7bfe0f022d

It was never going to last.

««« original CL description
cmd/api: break the builds

There is some question about whether the api tool is
running on Windows (see issue 6124), and now I'm
starting to question whether it runs on any of the builders,
since both darwin/amd64 and linux/amd64 are crashing for me
in the api tool due to a recent cgo-related change, and yet
the dashboard is happy.

If the dashboard is still happy after this CL, we have a problem.

Update issue 6124

TBR=golang-dev
CC=golang-dev
https://codereview.appspot.com/13632053
»»»

TBR=golang-dev
CC=golang-dev
https://codereview.appspot.com/13474045

Expand All Messages | Collapse All Messages