Issue 13385046: code review 13385046: cmd/api: fix tool for recent go/build change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13385046: code review 13385046: cmd/api: fix tool for recent go/build change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
gri

CC:
golang-dev

Visibility:
Public.

Description

cmd/api: fix tool for recent go/build change Asking about runtime/cgo when CgoEnabled=false now correctly returns an error from build.Import (specifically, NoGoError), because there are no buildable Go files in that directory. The API tool was depending on it returning a package with no Go files instead. Correct that assumption. Fixes all.bash on local machines. (Dashboard appears not to be running the api tool at all.) Update issue 6124

Patch Set 1 #

Patch Set 2 : diff -r 744fe06687cc https://code.google.com/p/go/ #

Patch Set 3 : diff -r 744fe06687cc https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/cmd/api/goapi.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-11 18:42:32 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=f29b1dbabddf *** cmd/api: fix tool for recent go/build change Asking about runtime/cgo ...

11 years, 6 months ago (2013-09-11 18:42:38 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages