Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/8g, runtime: 2c128d417029 broke finalisation for 386 platforms #5516

Closed
davecheney opened this issue May 20, 2013 · 6 comments
Closed

cmd/8g, runtime: 2c128d417029 broke finalisation for 386 platforms #5516

davecheney opened this issue May 20, 2013 · 6 comments

Comments

@davecheney
Copy link
Contributor

https://golang.org/cl/9557043

Has broken the build for all out 386 platforms.

# ../test
run                  fixedbugs/issue5493.go: incorrect output
panic: not all finalizers are called

goroutine 1 [running]:
main.main()
    /private/tmp/gobuilder/darwin-386-2c128d417029/go/test/fixedbugs/issue5493.go:49 +0x10d

goroutine 24 [finalizer wait]:
exit status 2

exit status 1

real    1m28.049s
user    2m2.731s
sys 0m24.815s
@dvyukov
Copy link
Member

dvyukov commented May 20, 2013

Comment 1:

Owner changed to @dvyukov.

Status changed to Started.

@ianlancetaylor
Copy link
Member

Comment 2:

Labels changed: added priority-asap, go1.1.1, removed priority-triage.

@dvyukov
Copy link
Member

dvyukov commented May 20, 2013

Comment 3:

This issue was closed by revision 910bd15.

Status changed to Fixed.

@ianlancetaylor
Copy link
Member

Comment 4:

Labels changed: removed go1.1.1.

@adg
Copy link
Contributor

adg commented Jun 4, 2013

Comment 5:

Labels changed: added go1.1.1.

@adg
Copy link
Contributor

adg commented Jun 5, 2013

Comment 6:

This issue was closed by revision 7d8b2bbe53e5.

@rsc rsc added this to the Go1.1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1.1 label Apr 14, 2015
adg added a commit that referenced this issue May 11, 2015
…se GC on 32-bits

««« CL 9573043 / c0f8999bd970
test: do not run the test that relies on precise GC on 32-bits
Currently most of the 32-bit builder are broken.
Fixes #5516.

R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/9573043
»»»

R=dvyukov, iant, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/10032043
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants