code review 10032043: [release-branch.go1.1] test: do not run the test that r...

[release-branch.go1.1] test: do not run the test that relies on precise GC on 32-bits

««« CL 9573043 / c0f8999bd970
test: do not run the test that relies on precise GC on 32-bits
Currently most of the 32-bit builder are broken.
Fixes issue 5516.

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/9573043
»»»

[adg, 2013-06-05 00:53:29]

Hello dvyukov, iant, minux (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-06-05 00:57:52]

LGTM



On Tue, Jun 4, 2013 at 5:53 PM, <adg@golang.org> wrote:

> Reviewers: dvyukov, iant, minux,
>
> Message:
> Hello dvyukov, iant, minux (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> [release-branch.go1.1] test: do not run the test that relies on precise
> GC on 32-bits
>
> ««« CL 9573043 / c0f8999bd970
> test: do not run the test that relies on precise GC on 32-bits
> Currently most of the 32-bit builder are broken.
> Fixes issue 5516.
>
> R=golang-dev, dave, iant
> CC=golang-dev
>
https://codereview.appspot.**com/9573043<https://codereview.appspot.com/9573043>
> »»»
>
>
> Please review this at
https://codereview.appspot.**com/10032043/<https://codereview.appspot.com/100...
>
> Affected files:
>   M test/fixedbugs/issue5493.go
>
>
> Index: test/fixedbugs/issue5493.go
> ==============================**==============================**=======
> --- a/test/fixedbugs/issue5493.go
> +++ b/test/fixedbugs/issue5493.go
> @@ -31,6 +31,11 @@
>  }
>
>  func main() {
> +       // Does not work on 32-bits due to partially conservative GC.
> +       // Try to enable when we have fully precise GC.
> +       if runtime.GOARCH != "amd64" {
> +               return
> +       }
>         count = N
>         var wg sync.WaitGroup
>         wg.Add(N)
> @@ -46,6 +51,7 @@
>                 runtime.GC()
>         }
>         if count != 0 {
> +               println(count, "out of", N, "finalizer are called")
>                 panic("not all finalizers are called")
>         }
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[adg, 2013-06-05 01:07:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=7d8b2bbe53e5 ***

[release-branch.go1.1] test: do not run the test that relies on precise GC on
32-bits

««« CL 9573043 / c0f8999bd970
test: do not run the test that relies on precise GC on 32-bits
Currently most of the 32-bit builder are broken.
Fixes issue 5516.

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/9573043
»»»

R=dvyukov, iant, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/10032043

[rsc, 2013-06-10 11:49:36]

LGTM