Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1213)

Issue 9573043: code review 9573043: test: do not run the test that relies on precise GC on ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by dvyukov
Modified:
10 years, 11 months ago
Reviewers:
iant
CC:
golang-dev, dave_cheney.net, iant
Visibility:
Public.

Description

test: do not run the test that relies on precise GC on 32-bits Currently most of the 32-bit builder are broken. Fixes issue 5516.

Patch Set 1 #

Patch Set 2 : diff -r 2d4825868d95 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 2d4825868d95 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d1d76fc0ab6a https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M test/fixedbugs/issue5493.go View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 11 months ago (2013-05-20 06:57:10 UTC) #1
dave_cheney.net
Thank you for this quick fix. I'm not sure that precise GC is exactly the ...
10 years, 11 months ago (2013-05-20 07:01:27 UTC) #2
dvyukov
On 2013/05/20 07:01:27, dfc wrote: > Thank you for this quick fix. > > I'm ...
10 years, 11 months ago (2013-05-20 07:08:51 UTC) #3
dave_cheney.net
> Frankly, I just do not want to spend time investigating. Even if main cause ...
10 years, 11 months ago (2013-05-20 07:14:04 UTC) #4
iant
LGTM
10 years, 11 months ago (2013-05-20 17:28:05 UTC) #5
dvyukov
10 years, 11 months ago (2013-05-20 17:53:38 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=c0f8999bd970 ***

test: do not run the test that relies on precise GC on 32-bits
Currently most of the 32-bit builder are broken.
Fixes issue 5516.

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/9573043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b