New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: go get fails for google code clones #5408
Labels
Milestone
Comments
hi beatgammit, do you want to contribute that patch? please read http://golang.org/doc/contribute.html if do. or we can take care the 1-line patch for you if you don't bother to set up the mercurial plugin (that is, you don't expect to contribute other patches in the near future). i think this is trivial and simple enough to fix for Go 1.1. Labels changed: added priority-soon, go1.1, removed priority-triage. Status changed to Accepted. |
Let's go ahead and do the code review: https://golang.org/cl/9210043/ I plan to submit patches after 1.1 is released, so this will be a nice simple intro to contributing. |
Issue #6030 has been merged into this issue. |
This issue was closed by revision 65f21ca. Status changed to Fixed. |
FWIW, reverting this CL. I tried to create such a clone earlier today and found that I cannot. On further inquiry I've been told that that feature has been turned off. I don't see a strong argument for making such imports work starting in Go 1.2 when you cannot create new ones. (It does appear that old ones are still available, but given that they won't work with Go pre-1.2 the benefit seems marginal at best.) |
This issue was updated by revision 913f1f1. R=golang-dev, dave, r CC=golang-dev https://golang.org/cl/13317046 |
To date this feature has NOT been turned off. I just created a clone of a code.google.com repo - specifically go9p. It wound up being code.google.com/r/<mumble>-go9p. Attempting to go get the cloned repo yields the dreaded invalid code.google.com/ import path error. The obvious workaround is to create a local copy, strip the VCS info out of it, and load it into github or bitbucket. This makes contributing fixes/enhancements upstream tedious and error prone. Please reconsider making the go tool chain recognize code.google.com/r paths. |
Comment 13 by majid@apsalar.com: I just cloned a /p/ repo and got a /r/ URL. It seems you can replace /r/ with /p/ and Google Code will redirect, so there is a work-around, but it's a simple change that would make for better usability. Case in point: Fails: go get code.google.com/r/majid-leveldb-go/leveldb Works: go get code.google.com/p/majid-leveldb-go/leveldb |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by beatgammit:
Attachments:
The text was updated successfully, but these errors were encountered: