Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go get fails for google code clones #5408

Closed
gopherbot opened this issue May 4, 2013 · 13 comments
Closed

cmd/go: go get fails for google code clones #5408

gopherbot opened this issue May 4, 2013 · 13 comments
Milestone

Comments

@gopherbot
Copy link

by beatgammit:

What steps will reproduce the problem?
1. go get code.google.com/r/beatgammit-go-net-websocket/websocket


What is the expected output?
go get fetches and builds the package


What do you see instead?
package code.google.com/r/beatgammit-go-net-websocket/websocket: invalid
code.google.com/ import path
"code.google.com/r/beatgammit-go-net-websocket/websocket"

Which compiler are you using (5g, 6g, 8g, gccgo)?
6g


Which operating system are you using?
Arch Linux x86_64


Which version are you using?  (run 'go version')
tried on both 1.0.3 and current head (outputs from go version)
go version go1.0.3
go version devel +8cca28e940ea Sun May 05 02:23:19 2013 +0800 linux/amd64


Please provide any additional information below.
I've attached a diff that works for me (clone at
http://code.google.com/r/beatgammit-websocket).
I don't know Google Code well enough to know if there are any other things to account
for, so I kept it strict.

Attachments:

  1. patch.diff (2132 bytes)
@minux
Copy link
Member

minux commented May 4, 2013

Comment 1:

hi beatgammit, do you want to contribute that patch?
please read http://golang.org/doc/contribute.html if do.
or we can take care the 1-line patch for you if you don't bother to set up the
mercurial plugin (that is, you don't expect to contribute other patches in the
near future).
i think this is trivial and simple enough to fix for Go 1.1.

Labels changed: added priority-soon, go1.1, removed priority-triage.

Status changed to Accepted.

@gopherbot
Copy link
Author

Comment 2 by beatgammit:

Let's go ahead and do the code review: https://golang.org/cl/9210043/
I plan to submit patches after 1.1 is released, so this will be a nice simple intro to
contributing.

@minux
Copy link
Member

minux commented May 5, 2013

Comment 3:

ok. just "hg mail 9210043" after Go 1.1 is released.

Labels changed: added priority-later, removed priority-soon, go1.1.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 4:

Labels changed: added go1.2maybe.

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 5:

Labels changed: added feature.

@robpike
Copy link
Contributor

robpike commented Aug 20, 2013

Comment 6:

Issue #6030 has been merged into this issue.

@robpike
Copy link
Contributor

robpike commented Aug 29, 2013

Comment 7:

This issue was closed by revision 65f21ca.

Status changed to Fixed.

@rsc
Copy link
Contributor

rsc commented Sep 13, 2013

Comment 8:

FWIW, reverting this CL. I tried to create such a clone earlier today and found that I
cannot. On further inquiry I've been told that that feature has been turned off. I don't
see a strong argument for making such imports work starting in Go 1.2 when you cannot
create new ones. (It does appear that old ones are still available, but given that they
won't work with Go pre-1.2 the benefit seems marginal at best.)

@rsc
Copy link
Contributor

rsc commented Sep 13, 2013

Comment 9:

This issue was updated by revision 913f1f1.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/13317046

@gopherbot
Copy link
Author

Comment 10 by wkharold:

To date this feature has NOT been turned off. I just created a clone of a
code.google.com repo - specifically go9p. It wound up being
code.google.com/r/<mumble>-go9p. Attempting to go get the cloned repo yields the
dreaded invalid code.google.com/ import path error. The obvious workaround is to create
a local copy, strip the VCS info out of it, and load it into github or bitbucket. This
makes contributing fixes/enhancements upstream tedious and error
prone. Please reconsider making the go tool chain recognize code.google.com/r paths.

@ianlancetaylor
Copy link
Contributor

Comment 11:

Cloning a code.google.com repo was turned off and then turned on again.  Reopening this
issue.  Unless cloning is turned off again.

Labels changed: added repo-main, release-go1.4, removed priority-later, go1.2maybe, feature.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Sep 15, 2014

Comment 12:

I don't think this is important enough.

Status changed to WorkingAsIntended.

@gopherbot
Copy link
Author

Comment 13 by majid@apsalar.com:

I just cloned a /p/ repo and got a /r/ URL. It seems you can replace /r/ with /p/ and
Google Code will redirect, so there is a work-around, but it's a simple change that
would make for better usability.
Case in point:
Fails: go get code.google.com/r/majid-leveldb-go/leveldb
Works: go get code.google.com/p/majid-leveldb-go/leveldb

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants