code review 13317046: cmd/go: do not support code.google.com/r/zzz projects

cmd/go: do not support code.google.com/r/zzz projects

This reverts CL 13261048. I have just learned that these are
no longer supported on code.google.com (that is, it is impossible
to create them), so there is little reason to add support in
Go 1.2.

Update issue 5408

[rsc, 2013-09-13 00:46:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-09-13 00:58:01]

LGTM.

On Fri, Sep 13, 2013 at 10:46 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/go: do not support code.google.com/r/zzz projects
>
> This reverts CL 13261048. I have just learned that these are
> no longer supported on code.google.com (that is, it is impossible
> to create them), so there is little reason to add support in
> Go 1.2.
>
> Update issue 5408
>
> Please review this at https://codereview.appspot.com/13317046/
>
> Affected files (+1, -1 lines):
>   M src/cmd/go/vcs.go
>
>
> Index: src/cmd/go/vcs.go
> ===================================================================
> --- a/src/cmd/go/vcs.go
> +++ b/src/cmd/go/vcs.go
> @@ -570,7 +570,7 @@
>         // Google Code - new syntax
>         {
>                 prefix: "code.google.com/",
> -               re:
>
`^(?P<root>code\.google\.com/[pr]/(?P<project>[a-z0-9\-]+)(\.(?P<subrepo>[a-z0-9\-]+))?)(/[A-Za-z0-9_.\-]+)*$`,
> +               re:
>
`^(?P<root>code\.google\.com/p/(?P<project>[a-z0-9\-]+)(\.(?P<subrepo>[a-z0-9\-]+))?)(/[A-Za-z0-9_.\-]+)*$`,
>                 repo:   "https://{root}",
>                 check:  googleCodeVCS,
>         },
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[r, 2013-09-13 01:19:21]

LGTM but please update the issue that triggered the original CL.

[rsc, 2013-09-13 01:48:02]

*** Submitted as https://code.google.com/p/go/source/detail?r=290bc6eaa85f ***

cmd/go: do not support code.google.com/r/zzz projects

This reverts CL 13261048. I have just learned that these are
no longer supported on code.google.com (that is, it is impossible
to create them), so there is little reason to add support in
Go 1.2.

Update issue 5408

R=golang-dev, dave, r
CC=golang-dev
https://codereview.appspot.com/13317046