Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(290)

Issue 9210043: cmd: make google code clones go gettable

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by beatgammit
Modified:
10 years, 8 months ago
Reviewers:
minux1, r
Visibility:
Public.

Description

cmd/go: make google code clones go gettable This is a minor change to the regex to allow code.google.com/r urls Fixes 5408

Patch Set 1 #

Patch Set 2 : diff -r 8cca28e940ea https://code.google.com/p/go #

Patch Set 3 : diff -r 8cca28e940ea https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/go/vcs.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
minux1
description: s|cmd:|cmd/go:| please.
11 years ago (2013-05-05 17:05:14 UTC) #1
r
is this CL still alive? i'm happy to make it happen either way.
10 years, 9 months ago (2013-08-20 01:21:40 UTC) #2
r
Anyone object to this going in? I'm not an expert but it looks right to ...
10 years, 9 months ago (2013-08-20 10:51:34 UTC) #3
r
LGTM
10 years, 8 months ago (2013-08-29 02:45:13 UTC) #4
r
10 years, 8 months ago (2013-08-29 02:46:00 UTC) #5
this is such a tiny change, and so long-standing, i'm going to use executive
power and create a separate CL for it so we can check it in
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b