New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/pprof: browser visualization on windows broken #9178
Labels
Milestone
Comments
I'm not sure how the "s/echo/one/" typo happened... By adding the "C:\Program Files (x86)\Google\Chrome\Application" directory (the default install location for chrome on x86-64 machines) to PATH does allow the browser to be found by pprof, and the result to be shown, so there doesn't look to be anything else wrong with the functionality. |
on windows, it should use "cmd /c start". cookieo9, could you please give https://golang.org/cl/180380043 a try? iant, do you think this is good for 1.4? Owner changed to @minux. Status changed to Started. |
I don't have a dev/tip environment set up for windows, but I applied the change to 1.4rc1 by hand, manually rebuilt cmd/pprof and got the following: The process cannot access the file because it is being used by another process. If I find the time I'll set up a proper testing environment and try the CL. |
CL https://golang.org/cl/180380043 mentions this issue. |
This issue was closed by revision c9d0c81. Status changed to Fixed. |
rsc
added a commit
that referenced
this issue
May 11, 2015
…en browser on windows ««« CL 180380043 / d56c648b069f cmd/pprof/internal/commands: add command to open browser on windows While we're at there, also add a message to prompt the user to install Graphviz if "dot" command is not found. Fixes #9178. LGTM=adg, alex.brainman, cookieo9, rsc R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman CC=golang-codereviews https://golang.org/cl/180380043 »»» TBR=minux CC=golang-codereviews https://golang.org/cl/186760043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
…en browser on windows ««« CL 180380043 / d56c648b069f cmd/pprof/internal/commands: add command to open browser on windows While we're at there, also add a message to prompt the user to install Graphviz if "dot" command is not found. Fixes golang#9178. LGTM=adg, alex.brainman, cookieo9, rsc R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman CC=golang-codereviews https://golang.org/cl/180380043 »»» TBR=minux CC=golang-codereviews https://golang.org/cl/186760043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 26, 2018
…en browser on windows ««« CL 180380043 / d56c648b069f cmd/pprof/internal/commands: add command to open browser on windows While we're at there, also add a message to prompt the user to install Graphviz if "dot" command is not found. Fixes golang#9178. LGTM=adg, alex.brainman, cookieo9, rsc R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman CC=golang-codereviews https://golang.org/cl/180380043 »»» TBR=minux CC=golang-codereviews https://golang.org/cl/186760043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
…en browser on windows ««« CL 180380043 / d56c648b069f cmd/pprof/internal/commands: add command to open browser on windows While we're at there, also add a message to prompt the user to install Graphviz if "dot" command is not found. Fixes golang#9178. LGTM=adg, alex.brainman, cookieo9, rsc R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman CC=golang-codereviews https://golang.org/cl/180380043 »»» TBR=minux CC=golang-codereviews https://golang.org/cl/186760043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 20, 2018
…en browser on windows ««« CL 180380043 / d56c648b069f cmd/pprof/internal/commands: add command to open browser on windows While we're at there, also add a message to prompt the user to install Graphviz if "dot" command is not found. Fixes golang#9178. LGTM=adg, alex.brainman, cookieo9, rsc R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman CC=golang-codereviews https://golang.org/cl/180380043 »»» TBR=minux CC=golang-codereviews https://golang.org/cl/186760043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
…en browser on windows ««« CL 180380043 / d56c648b069f cmd/pprof/internal/commands: add command to open browser on windows While we're at there, also add a message to prompt the user to install Graphviz if "dot" command is not found. Fixes golang#9178. LGTM=adg, alex.brainman, cookieo9, rsc R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman CC=golang-codereviews https://golang.org/cl/180380043 »»» TBR=minux CC=golang-codereviews https://golang.org/cl/186760043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: