Issue 186760043: code review 186760043: [release-branch.go1.4] cmd/pprof/internal/commands: add...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186760043: code review 186760043: [release-branch.go1.4] cmd/pprof/internal/commands: add... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 4 months ago by rsc

Modified:
9 years, 4 months ago

Reviewers:
minux

CC:
minux, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.4] cmd/pprof/internal/commands: add command to open browser on windows ««« CL 180380043 / d56c648b069f cmd/pprof/internal/commands: add command to open browser on windows While we're at there, also add a message to prompt the user to install Graphviz if "dot" command is not found. Fixes issue 9178. LGTM=adg, alex.brainman, cookieo9, rsc R=rsc, adg, bradfitz, alex.brainman, cookieo9, smyrman CC=golang-codereviews https://codereview.appspot.com/180380043 Committer: Russ Cox <rsc@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r 1daa56ce929994b71ceaf07aa9412e7cb7758d96 https://code.google.com/p/go/ #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	src/cmd/pprof/internal/commands/commands.go	View	1	4 chunks	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello minux (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 4 months ago (2014-12-04 16:25:23 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=229e10a28de1 *** [release-branch.go1.4] cmd/pprof/internal/commands: add command to open browser on windows ««« ...

9 years, 4 months ago (2014-12-04 16:25:30 UTC) #2

LGTM.

Expand All Messages | Collapse All Messages