Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regexp: ReplaceAllLiteralString doc comment starts with "ReplaceAllStringLiteral" #8959

Closed
extemporalgenome opened this issue Oct 19, 2014 · 3 comments
Closed

regexp: ReplaceAllLiteralString doc comment starts with "ReplaceAllStringLiteral" #8959

extemporalgenome opened this issue Oct 19, 2014 · 3 comments
Labels
FrozenDueToAge

Comments

@extemporalgenome
Copy link
Contributor 

What does 'go version' print?

go version devel +400e84516718 Sat Oct 18 11:22:05 2014 -0700 linux/amd64

What steps reproduce the problem?

Do either of the following:

1. godoc regexp ReplaceAllLiteralString
2. At the time of this writing, visit
http://tip.golang.org/pkg/regexp/#Regexp.ReplaceAllLiteralString

What happened?

The doc comment starts with "ReplaceAllStringLiteral"

What should have happened instead?

The doc comment should start with "ReplaceAllLiteralString" to match the
actual method name.
@ianlancetaylor
Copy link
Contributor

Comment 1:

Thanks for pointing this out.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/161790043 mentions this issue.

@ianlancetaylor
Copy link
Contributor

Comment 3:

This issue was closed by revision 3c5fd98.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@ianlancetaylor @wheatman
regexp: correct doc comment for ReplaceAllLiteralString
c55c74e 
Fixes golang#8959.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/161790043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@ianlancetaylor @wheatman
regexp: correct doc comment for ReplaceAllLiteralString
506a9ce 
Fixes golang#8959.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/161790043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@ianlancetaylor @wheatman
regexp: correct doc comment for ReplaceAllLiteralString
31d9cae 
Fixes golang#8959.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/161790043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@ianlancetaylor @wheatman
regexp: correct doc comment for ReplaceAllLiteralString
2fd4735 
Fixes golang#8959.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/161790043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@extemporalgenome @ianlancetaylor @gopherbot