Issue 161790043: code review 161790043: regexp: correct doc comment for ReplaceAllLiteralString

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 161790043: code review 161790043: regexp: correct doc comment for ReplaceAllLiteralString (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by iant

Modified:
9 years, 6 months ago

Reviewers:
adg

CC:
golang-codereviews, adg

Visibility:
Public.

Description

regexp: correct doc comment for ReplaceAllLiteralString Fixes issue 8959.

Patch Set 1 #

Patch Set 2 : diff -r a68abe0de0549ef5badc532665e8bb7b7c006a22 https://code.google.com/p/go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/regexp/regexp.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 6 months ago (2014-10-19 04:25:44 UTC) #1

iant

9 years, 6 months ago (2014-10-19 17:28:31 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f8143b226ad4 ***

regexp: correct doc comment for ReplaceAllLiteralString

Fixes issue 8959.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://codereview.appspot.com/161790043

Expand All Messages | Collapse All Messages