Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text/template: printf with single argument from pipeline panics during Execute #8950

Closed
alotabits opened this issue Oct 17, 2014 · 3 comments
Closed

text/template: printf with single argument from pipeline panics during Execute #8950

alotabits opened this issue Oct 17, 2014 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@alotabits
Copy link 

What does 'go version' print?

Playground 1.3.2

What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.

1. http://play.golang.org/p/Dr3gVjctk6
or
2. http://play.golang.org/p/iKMQTtM3Vb

What happened?

1. panic
or
2. 12panic

What should have happened instead?
1. {{
or
2. 123
@ianlancetaylor
Copy link
Member

Comment 1:

Labels changed: added repo-main, release-go1.5.

@gopherbot
Copy link
Contributor

Comment 2:

CL https://golang.org/cl/161750043 mentions this issue.

@robpike
Copy link
Contributor

robpike commented Oct 18, 2014

Comment 3:

This issue was closed by revision 1cd78ee.

Status changed to Fixed.

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@robpike @wheatman
text/template: fix bug in pipelined variadics

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
cc90ef6 
Simple bug in argument processing: The final arg may
be the pipeline value, in which case it gets bound to the
fixed argument section. The code got that wrong. Easy
to fix.

Fixes golang#8950.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/161750043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@robpike @wheatman
text/template: fix bug in pipelined variadics
82fe955 
Simple bug in argument processing: The final arg may
be the pipeline value, in which case it gets bound to the
fixed argument section. The code got that wrong. Easy
to fix.

Fixes golang#8950.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/161750043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@robpike @wheatman
text/template: fix bug in pipelined variadics
e793eb1 
Simple bug in argument processing: The final arg may
be the pipeline value, in which case it gets bound to the
fixed argument section. The code got that wrong. Easy
to fix.

Fixes golang#8950.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/161750043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@robpike @wheatman
text/template: fix bug in pipelined variadics
3f9ebc7 
Simple bug in argument processing: The final arg may
be the pipeline value, in which case it gets bound to the
fixed argument section. The code got that wrong. Easy
to fix.

Fixes golang#8950.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/161750043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
5 participants
@bradfitz @alotabits @ianlancetaylor @robpike @gopherbot