code review 161750043: text/template: fix bug in pipelined variadics

text/template: fix bug in pipelined variadics
Simple bug in argument processing: The final arg may
be the pipeline value, in which case it gets bound to the
fixed argument section. The code got that wrong. Easy
to fix.

Fixes issue 8950.

[r, 2014-10-17 18:15:46]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-10-18 09:47:53]

LGTM


On Fri, Oct 17, 2014 at 8:15 PM, <r@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> text/template: fix bug in pipelined variadics
> Simple bug in argument processing: The final arg may
> be the pipeline value, in which case it gets bound to the
> fixed argument section. The code got that wrong. Easy
> to fix.
>
> Fixes issue 8950.
>
> Please review this at https://codereview.appspot.com/161750043/
>
> Affected files (+13, -1 lines):
>   M src/text/template/exec.go
>   M src/text/template/exec_test.go
>
>
> Index: src/text/template/exec.go
> ===================================================================
> --- a/src/text/template/exec.go
> +++ b/src/text/template/exec.go
> @@ -546,7 +546,7 @@
>         argv := make([]reflect.Value, numIn)
>         // Args must be evaluated. Fixed args first.
>         i := 0
> -       for ; i < numFixed; i++ {
> +       for ; i < numFixed && i < len(args); i++ {
>                 argv[i] = s.evalArg(dot, typ.In(i), args[i])
>         }
>         // Now the ... args.
> Index: src/text/template/exec_test.go
> ===================================================================
> --- a/src/text/template/exec_test.go
> +++ b/src/text/template/exec_test.go
> @@ -893,6 +893,18 @@
>         }
>  }
>
> +func TestFinalForPrintf(t *testing.T) {
> +       tmpl, err := New("").Parse(`{{"x" | printf}}`)
> +       if err != nil {
> +               t.Fatal(err)
> +       }
> +       var b bytes.Buffer
> +       err = tmpl.Execute(&b, 0)
> +       if err != nil {
> +               t.Fatal(err)
> +       }
> +}
> +
>  type cmpTest struct {
>         expr  string
>         truth string
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-10-18 18:22:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=400e84516718 ***

text/template: fix bug in pipelined variadics
Simple bug in argument processing: The final arg may
be the pipeline value, in which case it gets bound to the
fixed argument section. The code got that wrong. Easy
to fix.

Fixes issue 8950.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/161750043