Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/cgo: Test8694 fails on armv6 devices #8816

Closed
davecheney opened this issue Sep 26, 2014 · 3 comments
Closed

runtime/cgo: Test8694 fails on armv6 devices #8816

davecheney opened this issue Sep 26, 2014 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@davecheney
Copy link
Contributor 

What steps will reproduce the problem?

# ../misc/cgo/test
testLibgcc is disabled on ARM because 5l cannot handle thumb library.
testLibgcc is disabled on ARM because 5l cannot handle thumb library.
testLibgcc is disabled on ARM because 5l cannot handle thumb library.
testLibgcc is disabled on ARM because 5l cannot handle thumb library.
testLibgcc is disabled on ARM because 5l cannot handle thumb library.
scatter = 0xd930
hello from C
sqrt is: 0
--- FAIL: Test8694 (0.00s)
        issue8694.go:23: C.complexFloatSquared((2+3i)) = (0+0i), want (-5+12i)
FAIL
exit status 1
FAIL    _/home/pi/go/misc/cgo/test      3.897s
What is the expected output? What do you see instead?

The test started to fail after revision b4a82354d400

Please use labels and text to provide additional information.

The test passes on armv7 devices, but fails on armv6 (VFPv1) devices.
@josharian
Copy link
Contributor

Comment 1:

Issue #8817 has been merged into this issue.

@josharian
Copy link
Contributor

Comment 2:

Owner changed to @randall77.

Status changed to Accepted.

@randall77
Copy link
Contributor

Comment 3:

This issue was closed by revision e1364a6.

Status changed to Fixed.

@josharian josharian mentioned this issue Dec 8, 2014
Closed
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@randall77 @wheatman
runtime: fix cgo_topofstack to save clobbered registers
bf9c91d 
Fixes golang#8816

At least, I hope it does.

TBR=rsc
CC=golang-codereviews
https://golang.org/cl/153730043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@randall77 @wheatman
runtime: fix cgo_topofstack to save clobbered registers
d9a8e22 
Fixes golang#8816

At least, I hope it does.

TBR=rsc
CC=golang-codereviews
https://golang.org/cl/153730043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@randall77 @wheatman
runtime: fix cgo_topofstack to save clobbered registers
d00f305 
Fixes golang#8816

At least, I hope it does.

TBR=rsc
CC=golang-codereviews
https://golang.org/cl/153730043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@randall77 @wheatman
runtime: fix cgo_topofstack to save clobbered registers
9a2a74c 
Fixes golang#8816

At least, I hope it does.

TBR=rsc
CC=golang-codereviews
https://golang.org/cl/153730043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
5 participants
@davecheney @josharian @rsc @randall77 @gopherbot