Issue 153730043: code review 153730043: runtime: fix cgo_topofstack to save clobbered registers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153730043: code review 153730043: runtime: fix cgo_topofstack to save clobbered registers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by khr

Modified:
9 years, 7 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: fix cgo_topofstack to save clobbered registers Fixes issue 8816 At least, I hope it does.

Patch Set 1 #

Patch Set 2 : diff -r 9472d0e26c23a691539de7cf0a81b6c3a569455a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9472d0e26c23a691539de7cf0a81b6c3a569455a https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9472d0e26c23a691539de7cf0a81b6c3a569455a https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/runtime/asm_arm.s	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

khr

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-29 06:52:06 UTC) #1

khr

*** Submitted as https://code.google.com/p/go/source/detail?r=3d8bc2ff5bcf *** runtime: fix cgo_topofstack to save clobbered registers Fixes issue 8816 ...

9 years, 7 months ago (2014-09-29 06:52:12 UTC) #2

gobot

This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/1ca48ab3bb455e9dfa455a00bfc39aa2ef199fab

9 years, 7 months ago (2014-09-29 07:55:17 UTC) #3

LGTM

Expand All Messages | Collapse All Messages