Skip to content

net/http/httputil: ReverseProxy logs an error that cannot be surpressed #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 19, 2014 · 5 comments
Closed

net/http/httputil: ReverseProxy logs an error that cannot be surpressed #8553

gopherbot opened this issue Aug 19, 2014 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@gopherbot
Copy link
Contributor

by mark.theunissen:

What does 'go version' print?

go version go1.3 darwin/amd64

However I've looked at the codebase and the code still exists in HEAD.

What steps reproduce the problem?

The ReverseProxy calls `log` to output a failure message to StdErr, on line 141 of
http://golang.org/src/pkg/net/http/httputil/reverseproxy.go

What happened?

Error message appears in logs.

What should have happened instead?

We don't consider this failure to be an error, and we'd like to surpress this error
message, however it's hardcoded in the Go source. Could it be removed?
@bradfitz
Copy link
Contributor

Comment 1:

We can add a Logger field to ReverseProxy like we did to net/http.Server.

Labels changed: added release-go1.4, repo-main.

Status changed to Accepted.

@gopherbot
Copy link
Contributor Author

Comment 3 by mark@getpantheon.com:

Created a patch here: https://golang.org/cl/132750043

@gopherbot
Copy link
Contributor Author

Comment 4 by mark.theunissen:

Patch created here: https://golang.org/cl/132750043

@gopherbot
Copy link
Contributor Author

Comment 5:

CL https://golang.org/cl/132750043 mentions this issue.

@bradfitz
Copy link
Contributor

Comment 6:

This issue was closed by revision 1a1d432.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@marktheunissen @wheatman
net/http/httputil: Pass a Logger to ReverseProxy, allowing the user t…
b160610 
…o control logging.

Fixes golang#8553.

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/132750043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@marktheunissen @wheatman
net/http/httputil: Pass a Logger to ReverseProxy, allowing the user t…
06a1833 
…o control logging.

Fixes golang#8553.

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://golang.org/cl/132750043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot