Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1592)

Issue 132750043: code review 132750043: net/http/httputil: Pass a Logger to ReverseProxy, allow...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by mark.theunissen
Modified:
9 years, 8 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, dave_cheney.net, bradfitz
Visibility:
Public.

Description

net/http/httputil: Pass a Logger to ReverseProxy, allowing the user to control logging. Fixes issue 8553.

Patch Set 1 #

Patch Set 2 : diff -r d290f48255fb933439916159ecd5301c5bb5c301 https://code.google.com/p/go #

Patch Set 3 : diff -r d290f48255fb933439916159ecd5301c5bb5c301 https://code.google.com/p/go #

Patch Set 4 : diff -r d290f48255fb933439916159ecd5301c5bb5c301 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/pkg/net/http/httputil/reverseproxy.go View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 6
mark.theunissen
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2014-08-21 10:08:54 UTC) #1
dave_cheney.net
On 2014/08/21 10:08:54, mark.theunissen wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
9 years, 8 months ago (2014-08-21 10:17:01 UTC) #2
mark.theunissen
Hello golang-codereviews@googlegroups.com, dave@cheney.net (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 8 months ago (2014-08-21 10:41:57 UTC) #3
mark.theunissen
On 2014/08/21 10:17:01, dfc wrote: > On 2014/08/21 10:08:54, mark.theunissen wrote: > > Hello mailto:golang-codereviews@googlegroups.com, ...
9 years, 8 months ago (2014-08-21 10:42:48 UTC) #4
bradfitz
LGTM
9 years, 8 months ago (2014-08-21 17:15:23 UTC) #5
bradfitz
9 years, 8 months ago (2014-08-21 17:16:39 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=37e79b15b66f ***

net/http/httputil: Pass a Logger to ReverseProxy, allowing the user to control
logging.

Fixes issue 8553.

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/132750043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b