Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get vanity.com/repo/... fails when not already there #8335

Closed
rogpeppe opened this issue Jul 7, 2014 · 3 comments
Closed

cmd/go: go get vanity.com/repo/... fails when not already there #8335

rogpeppe opened this issue Jul 7, 2014 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@rogpeppe
Copy link
Contributor

rogpeppe commented Jul 7, 2014 

For example:

(ensure that $GOPATH/src/labix.org/v2/mgo does not exist)
$ go get labix.org/v2/mgo
package labix.org/v2/mgo/...: unrecognized import path "labix.org/v2/mgo/..."

"go get labix.org/v2/mgo" (without the ./...) succeeds.

They should both work (which would make "go get -d $reporoot/..."
a viable way to pull an entire repo without dependencies).
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added repo-main, release-go1.4.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/146310043 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Sep 26, 2014

Comment 3:

This issue was closed by revision 7fa96f0.

Status changed to Fixed.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
cmd/go: fix 'go get vanity/repo/...' in clean GOPATH
a6d8600 
The pattern was only working if the checkout had
already been done, but the code was trying to make
it work even the first time. Test and fix.

Fixes golang#8335.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://golang.org/cl/146310043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@rsc @wheatman
cmd/go: fix 'go get vanity/repo/...' in clean GOPATH
f907629 
The pattern was only working if the checkout had
already been done, but the code was trying to make
it work even the first time. Test and fix.

Fixes golang#8335.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://golang.org/cl/146310043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
cmd/go: fix 'go get vanity/repo/...' in clean GOPATH
c02b77e 
The pattern was only working if the checkout had
already been done, but the code was trying to make
it work even the first time. Test and fix.

Fixes golang#8335.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://golang.org/cl/146310043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@rsc @wheatman
cmd/go: fix 'go get vanity/repo/...' in clean GOPATH
a1cc3b7 
The pattern was only working if the checkout had
already been done, but the code was trying to make
it work even the first time. Test and fix.

Fixes golang#8335.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://golang.org/cl/146310043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
4 participants
@rogpeppe @rsc @ianlancetaylor @gopherbot