Issue 146310043: code review 146310043: cmd/go: fix 'go get vanity/repo/...' in clean GOPATH

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 146310043: code review 146310043: cmd/go: fix 'go get vanity/repo/...' in clean GOPATH (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
golang-codereviews, r, iant

Visibility:
Public.

Description

cmd/go: fix 'go get vanity/repo/...' in clean GOPATH The pattern was only working if the checkout had already been done, but the code was trying to make it work even the first time. Test and fix. Fixes issue 8335.

Patch Set 1 #

Patch Set 2 : diff -r b811c3bc6cda5e9140e3774304b7cb1270518d6e https://code.google.com/p/go/ #

Patch Set 3 : diff -r b811c3bc6cda5e9140e3774304b7cb1270518d6e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8f36a32a9d036f86fb956c8538142eb384bd1a4a https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	src/cmd/go/test.bash	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	src/cmd/go/vcs.go	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-25 21:15:06 UTC) #1

rsc

9 years, 7 months ago (2014-09-26 16:09:33 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=39d7b8f3a599 ***

cmd/go: fix 'go get vanity/repo/...' in clean GOPATH

The pattern was only working if the checkout had
already been done, but the code was trying to make
it work even the first time. Test and fix.

Fixes issue 8335.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://codereview.appspot.com/146310043

Expand All Messages | Collapse All Messages