cmd/gofmt: nonidempotent format of expression #8021
Labels
Milestone
Comments
|
Owner changed to @griesemer. Status changed to Accepted. |
Tentative fix: https://golang.org/cl/92380051 You can patch this CL and it will fix your specific problem. It doesn't impact the std lib but it may impact other code. Also, I like to understand the consequences better and perhaps be a bit more aggressive with parentheses removal. Not crucial for 1.3. Labels changed: added release-go1.4. Status changed to Started. |
CL https://golang.org/cl/142020043 mentions this issue. |
|
This issue was closed by revision a14c1c9. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
…nt around an expr No impact on formatting on our repos. Fixes golang#8021. LGTM=adonovan R=adonovan, dvyukov CC=golang-codereviews https://golang.org/cl/142020043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
…nt around an expr No impact on formatting on our repos. Fixes golang#8021. LGTM=adonovan R=adonovan, dvyukov CC=golang-codereviews https://golang.org/cl/142020043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
…nt around an expr No impact on formatting on our repos. Fixes golang#8021. LGTM=adonovan R=adonovan, dvyukov CC=golang-codereviews https://golang.org/cl/142020043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
go version devel +386c6757d94c Sat May 17 00:06:56 2014 +0000 + darwin/amd64 source is: package main func main() { _ = ([]bool{})[([]int{})[((1) + (((((1) + (((((((1) * (((((1) + (1))) + (1))))) + (1))) * (1))))) + (1))))]] } The following line: _ = ([]bool{})[([]int{})[((1) + (((((1) + (((((((1) * (((((1) + (1))) + (1))))) + (1))) * (1))))) + (1))))]] transforms to the following after first gofmt: _ = ([]bool{})[([]int{})[((1)+(((1) + ((((1) * (((1) + (1)) + (1))) + (1)) * (1))) + (1)))]] and to the following after second gofmt: _ = ([]bool{})[([]int{})[((1)+(((1)+((((1)*(((1)+(1))+(1)))+(1))*(1)))+(1)))]] Second gofmt must not change source.The text was updated successfully, but these errors were encountered: