code review 142020043: go/printer: don't reduce nesting depth twice if paramet...

go/printer: don't reduce nesting depth twice if parentheses are present around an expr

No impact on formatting on our repos.

Fixes issue 8021.

[gri, 2014-09-11 23:47:37]

Hello adonovan, dvyukov (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[dvyukov, 2014-09-12 00:09:56]

Why am I here?

s/parameters/parens/ in the description

[gri, 2014-09-12 17:08:03]

CL desc fixed.

You (dvyukov) are on this because this is a bug you reported some time back
and I had a temp. patch for you at that time. This is the same patch w/
test cases, ready to be submitted for good.

- gri


On Thu, Sep 11, 2014 at 5:09 PM, <dvyukov@google.com> wrote:

> Why am I here?
>
> s/parameters/parens/ in the description
>
>
> https://codereview.appspot.com/142020043/
>

[adonovan, 2014-09-12 18:14:18]

On 2014/09/12 17:08:03, gri wrote:
> CL desc fixed.
> 
> You (dvyukov) are on this because this is a bug you reported some time back
> and I had a temp. patch for you at that time. This is the same patch w/
> test cases, ready to be submitted for good.
> 
> - gri
> 
> 
> On Thu, Sep 11, 2014 at 5:09 PM, <mailto:dvyukov@google.com> wrote:
> 
> > Why am I here?
> >
> > s/parameters/parens/ in the description
> >
> >
> > https://codereview.appspot.com/142020043/
> >

LGTM

[gri, 2014-09-12 18:18:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=b4e2a93cc930 ***

go/printer: don't reduce nesting depth twice if parentheses are present around
an expr

No impact on formatting on our repos.

Fixes issue 8021.

LGTM=adonovan
R=adonovan, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/142020043

[gobot, 2014-09-12 18:20:39]

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/1c1d08fb8a8f07d180ca9b1b920165feda078c3c

[dvyukov, 2014-09-12 18:31:25]

On Fri, Sep 12, 2014 at 10:08 AM, Robert Griesemer <gri@golang.org> wrote:
> CL desc fixed.
>
> You (dvyukov) are on this because this is a bug you reported some time back
> and I had a temp. patch for you at that time. This is the same patch w/ test
> cases, ready to be submitted for good.

ah, OK, missed "Fixes issue" part
good, we can revive gofmt testing under gosmith