Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportClosesBodyOnError times out on Plan 9 #7782

Closed
0intro opened this issue Apr 14, 2014 · 6 comments
Closed

net/http: TestTransportClosesBodyOnError times out on Plan 9 #7782

0intro opened this issue Apr 14, 2014 · 6 comments
Labels
FrozenDueToAge OS-Plan9 Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unplanned

Comments

@0intro
Copy link
Member

0intro commented Apr 14, 2014 

What steps will reproduce the problem?

% cd src/pkg/net/http
% go test -short -run TestTransportClosesBodyOnError

What is the expected output? What do you see instead?

The test is timing out because ioutil.ReadAll(r.Body) never returns.

This test was introduced in CL 85560045 and timed out something like one time out of
five. Starting with CL 87640043, the test is always timing out.

http://build.golang.org/log/cef5eaa08289cf6e33827cd844ee406d65542370
@bradfitz
Copy link
Contributor

Comment 1:

Since we don't ship binaries for Plan 9, removing the Release-Go1.3 label from this.

Labels changed: added release-go1.3maybe, os-plan9, removed release-go1.3.

@0intro
Copy link
Member Author

0intro commented Apr 15, 2014

Comment 2:

This issue happens because closing the TCP connection
does not wake up the readers.
We have to properly implement handling of close (as long
as timeout, see issue #7237) in the net package on Plan 9.
The CL 87800044 temporarily skip this test.

@0intro
Copy link
Member Author

0intro commented Apr 15, 2014

Comment 3:

Owner changed to @0intro.

@rsc
Copy link
Contributor

rsc commented May 9, 2014

Comment 4:

Labels changed: added release-none, suggested, removed release-go1.3maybe.

Status changed to Accepted.

@ianlancetaylor
Copy link
Contributor

Comment 5:

Labels changed: added repo-main.

@0intro 0intro added accepted Suggested Issues that may be good for new contributors looking for work to do. labels May 9, 2014
@0intro 0intro mentioned this issue Jan 9, 2015
Closed
@rsc rsc removed the os-plan9 label Apr 10, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@0intro 0intro self-assigned this Jul 30, 2015
@gopherbot
Copy link

CL https://golang.org/cl/15941 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 17, 2016
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9 Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@bradfitz @rsc @ianlancetaylor @0intro @gopherbot