Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: failing tests on Plan 9 #7237

Closed
0intro opened this issue Jan 30, 2014 · 8 comments
Closed

net/http: failing tests on Plan 9 #7237

0intro opened this issue Jan 30, 2014 · 8 comments
Labels
FrozenDueToAge OS-Plan9
Milestone
Unplanned

Comments

@0intro
Copy link
Member

0intro commented Jan 30, 2014 

What steps will reproduce the problem?

cd pkg/net/http; go test -short

What is the expected output? What do you see instead?

The following tests are failing:

serve_test.go

    TestServerTimeouts
    TestOnlyWriteTimeout
    TestTLSHandshakeTimeout
    TestClientWriteShutdown

transport_test.go

    TestTransportPersistConnLeak
    TestTransportPersistConnLeakShortBody
    TestIssue4191_InfiniteGetTimeout
    TestIssue4191_InfiniteGetToPutTimeout

The timeout tests are failing because of the lack of deadline support. The other issues
are:

--- FAIL: TestClientWriteShutdown (0.01 seconds)
        serve_test.go:1430: Dial: not supported by plan 9

--- FAIL: TestTransportPersistConnLeak (0.82 seconds)
        transport_test.go:803: goroutine growth: 93 -> 193 -> 99 (delta: 6)
        transport_test.go:804: too many new goroutines

--- FAIL: TestTransportPersistConnLeakShortBody (1.10 seconds)
        transport_test.go:843: goroutine growth: 93 -> 153 -> 153 (delta: 60)
        transport_test.go:845: too many new goroutines
@0intro
Copy link
Member Author

0intro commented Jan 30, 2014

Comment 1:

This issue was updated by revision 73b0d84.

LGTM=bradfitz
R=jas, bradfitz
CC=golang-codereviews
https://golang.org/cl/57190045

@davecheney
Copy link
Contributor

Comment 3:

Labels changed: added release-none, repo-main.

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 4:

Labels changed: added os-plan9.

@0intro 0intro mentioned this issue Jan 9, 2015
Closed
@rsc rsc removed the os-plan9 label Apr 10, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@bradfitz bradfitz mentioned this issue Jul 30, 2015
Closed
@0intro 0intro self-assigned this Jul 30, 2015
@gopherbot
Copy link

CL https://golang.org/cl/15941 mentions this issue.

bradfitz added a commit that referenced this issue Oct 16, 2015
@bradfitz
net: unblock plan9 TCP Read calls after socket close
368f73b 
Fixes #7782
Fixes #9554
Updates #7237 (original metabug, before we switched to specific bugs)
Updates #11932 (plan9 still doesn't have net I/O deadline support)

Change-Id: I96f311b88b1501d884ebc008fd31ad2cf1e16d75
Reviewed-on: https://go-review.googlesource.com/15941
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: David du Colombier <0intro@gmail.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/30164 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 3, 2016
@bradfitz
net: clarify that Conn deadlines also affect currently-blocked I/O
5f36e9a 
All implementations have always implemented this behavior, it's
tested, and it's depended on by other packages. (notably, by net/http)

The one exception is Plan 9 which doesn't support I/O deadlines at all
(tracked in #11932). As a result, a bunch of tests fail on plan9
(#7237). But once Plan 9 adds I/O deadline support, it'll also need
this behavior.

Change-Id: Idb71767f0c99279c66dce29f7bdc78ef467e47aa
Reviewed-on: https://go-review.googlesource.com/30164
Reviewed-by: Sam Whited <sam@samwhited.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/33197 mentions this issue.

@0intro 0intro mentioned this issue Nov 13, 2016
Open
gopherbot pushed a commit that referenced this issue Nov 13, 2016
@0intro @bradfitz
net/http: enable timeout tests on Plan 9
4a381e3 
Deadlines have been implemented on Plan 9 in CL 31521.

Enable the following tests:

 - TestServerTimeouts
 - TestOnlyWriteTimeout
 - TestTLSHandshakeTimeout
 - TestIssue4191_InfiniteGetTimeout
 - TestIssue4191_InfiniteGetToPutTimeout

Updates #7237.

Change-Id: If5e75cfaa9133dcf9ce6aac9fc2badafc1612b64
Reviewed-on: https://go-review.googlesource.com/33197
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz
Copy link
Contributor

bradfitz commented Jan 6, 2017

I think this is basically done. I'll create a new bug for the one test I still see mentioning plan9.

@bradfitz
Copy link
Contributor

bradfitz commented Jan 6, 2017

Actually, #17906 is already open. We can close this bug.

@bradfitz bradfitz closed this as completed Jan 6, 2017
@golang golang locked and limited conversation to collaborators Jan 7, 2018
@bcmills bcmills mentioned this issue Oct 19, 2020
Open
@rsc rsc unassigned 0intro Jun 23, 2022
@bcmills bcmills mentioned this issue Mar 16, 2023
Open
@golang golang unlocked this conversation Mar 16, 2023
@golang golang locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
5 participants
@bradfitz @davecheney @rsc @0intro @gopherbot