Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: server TLS handshake failures are silent #7291

Closed
gopherbot opened this issue Feb 9, 2014 · 3 comments
Closed

net/http: server TLS handshake failures are silent #7291

gopherbot opened this issue Feb 9, 2014 · 3 comments
Milestone

Comments

@gopherbot
Copy link

by mfischer@zendesk.com:

The serve() function of net/http calls tlsConn.Handshake() if a TLS connection is used,
but fails to expose any handshake errors that would be useful for debugging.  

if err := tlsConn.Handshake(); err != nil {                
        return
}

This makes it impossible for a user of net/http's Serve() methods to report handshake
errors such as bad certificates, bad protocol versions, etc.
@bradfitz
Copy link
Contributor

Comment 1:

Labels changed: added release-go1.3maybe, repo-main.

Owner changed to @bradfitz.

Status changed to Accepted.

@bradfitz
Copy link
Contributor

Comment 2:

Sent https://golang.org/cl/70250044

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 3:

This issue was closed by revision 281088b.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants