Issue 70250044: code review 70250044: net/http: add Server.ErrorLog; log and test TLS handsha...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 70250044: code review 70250044: net/http: add Server.ErrorLog; log and test TLS handsha... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by bradfitz

Modified:
10 years, 2 months ago

Reviewers:
agl1, gobot

CC:
golang-codereviews, agl1, agl

Visibility:
Public.

Description

net/http: add Server.ErrorLog; log and test TLS handshake errors Fixes Issue 7291

Patch Set 2 : diff -r 11019c720b58 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 3 : diff -r 79dcc3dbbace https://go.googlecode.com/hg/ #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -7 lines)			Patch
M	src/pkg/net/http/client_test.go	View	1 2	7 chunks	+31 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/serve_test.go	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/server.go	View	1	9 chunks	+22 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: agl@chromium.org), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 2 months ago (2014-02-28 20:01:51 UTC) #1

agl1

LGTM https://codereview.appspot.com/70250044/diff/20001/src/pkg/net/http/client_test.go File src/pkg/net/http/client_test.go (right): https://codereview.appspot.com/70250044/diff/20001/src/pkg/net/http/client_test.go#newcode648 src/pkg/net/http/client_test.go:648: type chanWriter chan string This is used higher ...

10 years, 2 months ago (2014-02-28 20:06:41 UTC) #2

bradfitz

https://codereview.appspot.com/70250044/diff/20001/src/pkg/net/http/server.go File src/pkg/net/http/server.go (right): https://codereview.appspot.com/70250044/diff/20001/src/pkg/net/http/server.go#newcode2031 src/pkg/net/http/server.go:2031: log.Printf("%s.Write(%d) = ....", c.name, len(p)) On 2014/02/28 20:06:42, agl1 ...

10 years, 2 months ago (2014-02-28 20:10:18 UTC) #3

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=26162125c6bd *** net/http: add Server.ErrorLog; log and test TLS handshake errors Fixes ...

10 years, 2 months ago (2014-02-28 20:12:53 UTC) #4

gobot

10 years, 2 months ago (2014-02-28 20:26:50 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the windows-386-ec2 builder.

Expand All Messages | Collapse All Messages