Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "go test -test.bench=does-not-match -c" hangs #6480

Closed
gopherbot opened this issue Sep 25, 2013 · 3 comments
Closed

cmd/go: "go test -test.bench=does-not-match -c" hangs #6480

gopherbot opened this issue Sep 25, 2013 · 3 comments
Milestone

Comments

@gopherbot
Copy link

The combination of -c and -test.bench causes a hang in go test.
-test.run=does-not-match does not suffer from this.

Running Go tip 18225:9c91baff43a1.

Any go package with tests will reproduce this, e.g.

$ cd $(go env GOROOT)/src/pkg/flag && go test -c -test.bench=does-not-match -x
WORK=/home/tv/tmp/go-build304342983
mkdir -p $WORK/flag/_test/
cd /home/tv/src/go/src/pkg/flag
/home/tv/src/go/pkg/tool/linux_amd64/6g -o $WORK/flag/_test/_go_.6 -p flag -complete -D
_/home/tv/src/go/src/pkg/flag -I $WORK ./flag.go ./export_test.go
/home/tv/src/go/pkg/tool/linux_amd64/pack grcP $WORK $WORK/flag/_test/flag.a
$WORK/flag/_test/_go_.6
/home/tv/src/go/pkg/tool/linux_amd64/6g -o $WORK/flag/_test/_go_.6 -p flag_test
-complete -D _/home/tv/src/go/src/pkg/flag -I $WORK/flag/_test -I $WORK
./example_test.go ./flag_test.go
/home/tv/src/go/pkg/tool/linux_amd64/pack grcP $WORK $WORK/flag/_test/flag_test.a
$WORK/flag/_test/_go_.6
cd $WORK/flag/_test
/home/tv/src/go/pkg/tool/linux_amd64/6g -o ./_go_.6 -p testmain -complete -D
"" -I . -I $WORK ./_testmain.go
/home/tv/src/go/pkg/tool/linux_amd64/pack grcP $WORK ./main.a ./_go_.6
cd .
/home/tv/src/go/pkg/tool/linux_amd64/6l -o $WORK/flag/_test/flag.test -L
$WORK/flag/_test -L $WORK $WORK/flag/_test/main.a


Inspecting $WORK or ps confirms the main.a was created and 6l has exited.
@minux
Copy link
Member

minux commented Sep 25, 2013

Comment 1:

"-x" is not necessary to reproduce the bug.
e.g.
go test -c -test.bench=X fmt # any other packages will do.

Labels changed: added priority-soon, go1.2, removed priority-triage.

Status changed to Accepted.

@minux
Copy link
Member

minux commented Sep 25, 2013

Comment 2:

https://golang.org/cl/13925043

Owner changed to @minux.

Status changed to Started.

@minux
Copy link
Member

minux commented Sep 25, 2013

Comment 3:

This issue was closed by revision 752960a.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants