Issue 13925043: code review 13925043: cmd/go: "go test -c -test.bench=XX fmt" shouldn't hang

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13925043: code review 13925043: cmd/go: "go test -c -test.bench=XX fmt" shouldn't hang (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by minux1

Modified:
10 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/go: "go test -c -test.bench=XX fmt" shouldn't hang Fixes issue 6480.

Patch Set 1 #

Patch Set 2 : diff -r 9c91baff43a1 https://code.google.com/p/go #

Patch Set 3 : diff -r 9c91baff43a1 https://code.google.com/p/go #

Patch Set 4 : diff -r 9c91baff43a1 https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	src/cmd/go/test.bash	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download
	M	src/cmd/go/test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 7 months ago (2013-09-25 20:03:00 UTC) #1

minux1

10 years, 7 months ago (2013-09-25 20:18:41 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d744da8c8cbf ***

cmd/go: "go test -c -test.bench=XX fmt" shouldn't hang
Fixes issue 6480.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13925043

Expand All Messages | Collapse All Messages