Skip to content

x/tools/cmd/godoc: Use relative (not absolute) font sizes #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jayschwa opened this issue Aug 14, 2013 · 7 comments
Closed

x/tools/cmd/godoc: Use relative (not absolute) font sizes #6150

jayschwa opened this issue Aug 14, 2013 · 7 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@jayschwa
Copy link
Contributor 

I changed my browser's default font size to be larger. (Note: this is different than
page zoom.) Go's online documentation does not respect this because sizes are hardcoded
to pixels inside godoc's style.css. It would be nice if style.css were updated to use
relative units (e.g. em) instead.
@jayschwa
Copy link
Contributor Author

Comment 1:

I'm willing to work on these changes myself if there is no opposition. I just did a
quick test where I stripped out all font-size lines in style.css... it looked more or
less the same when the browser's default font size is medium.

@robpike
Copy link
Contributor

robpike commented Aug 15, 2013

Comment 2:

Labels changed: added priority-later, removed priority-triage, go1.2maybe.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 3:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-tools.

@gopherbot
Copy link
Contributor

Comment 6:

CL https://golang.org/cl/133380043 mentions this issue.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title cmd/godoc: Use relative (not absolute) font sizes x/tools/cmd/godoc: Use relative (not absolute) font sizes Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/94935 mentions this issue: godoc: use relative css unit for font size

@golang golang locked and limited conversation to collaborators Apr 27, 2019
henderjon pushed a commit to oggodoc/godoc that referenced this issue Jun 13, 2024
@agnivade @andybons
godoc: use relative css unit
6402540 
To scale the website elements independently of the default font size,
we use the css rem unit. This scales the elements proportionally if the
user has set a different font size than the default.

We make all calculations assuming that 1rem=16px, which is the
default font size for browsers.

Tested manually on FF 59 and Chrome 65 with permutations of different
resolutions and different default font-sizes upto 36px.

Fixes golang/go#6150

Change-Id: I7ded227ee2c55178271667009ab98ee0b4e7e8b3
Reviewed-on: https://go-review.googlesource.com/94935
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@rsc @jayschwa @robpike @gopherbot