Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4768)

Issue 133380043: code review 133380043: go.tools/godoc: Use relative font sizes

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by dupoxy
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-codereviews, adg
Visibility:
Public.

Description

go.tools/godoc: Use relative font sizes Fixes Issue 6150

Patch Set 1 #

Patch Set 2 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 37b8aca2b320 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M godoc/static/style.css View 12 chunks +20 lines, -19 lines 0 comments Download

Messages

Total messages: 7
dupoxy
I did run ./bake.sh but codereview is saying that the resulting static.go file is to ...
9 years, 8 months ago (2014-08-30 19:56:25 UTC) #1
dupoxy
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 8 months ago (2014-08-30 19:57:26 UTC) #2
adg
Inconsistencies introduced by this change: (old vs new) - Table of contents font size too ...
9 years, 8 months ago (2014-09-01 01:59:42 UTC) #3
dupoxy
Hello golang-codereviews@googlegroups.com, adg@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 7 months ago (2014-09-01 16:53:30 UTC) #4
adg
There are still some inconsistencies. Actually, more than before: both the indices and all pre-formatted ...
9 years, 7 months ago (2014-09-01 22:25:52 UTC) #5
adg
Here are the before/after godoc binaries for darwin/amd64 if someone else wants to have a ...
9 years, 7 months ago (2014-09-01 22:49:46 UTC) #6
gobot
9 years, 4 months ago (2014-12-19 05:12:28 UTC) #7
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/133380043 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b