Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/api: include const expressions or values in api.txt #5935

Closed
rsc opened this issue Jul 22, 2013 · 7 comments
Closed

cmd/api: include const expressions or values in api.txt #5935

rsc opened this issue Jul 22, 2013 · 7 comments
Labels
FrozenDueToAge
Milestone
Go1.2

Comments

@rsc
Copy link
Contributor

rsc commented Jul 22, 2013 

The api.txt file does not include the values of constants. It needs to do so.
Named constants must not change value over the lifetime of Go 1.
If we have made any such mistakes already, we need to identify them.
We need to have this fix in place for Go 1.2 to prevent future mistakes.
@bradfitz
Copy link
Contributor

Comment 1:

In pkg syscall, at least IFLA_MAX went from 0x1c to 0x1d from go1 to tip in
ztypes_linux_386.go.  There are likely more.

@rsc
Copy link
Contributor Author

rsc commented Jul 22, 2013

Comment 2:

It matters when the tip change happened (before or after go1). Let's make
cmd/api tell us the full set and then decide what to do.

@robpike
Copy link
Contributor

robpike commented Jul 23, 2013

Comment 3:

Issue #5934 has been merged into this issue.

@bradfitz
Copy link
Contributor

bradfitz commented Sep 6, 2013

Comment 4:

This issue was updated by revision 8a70b50.

R=golang-dev, rsc, iant, dave
CC=golang-dev
https://golang.org/cl/13261050

@rsc
Copy link
Contributor Author

rsc commented Sep 9, 2013

Comment 5:

Brad, what's left?

@bradfitz
Copy link
Contributor

bradfitz commented Sep 9, 2013

Comment 6:

*** Submitted as https://code.google.com/p/go/source/detail?r=b5b740661b90 ***
cmd/api: include constant values
Update issue #5935
R=golang-dev, rsc, iant, dave
CC=golang-dev
https://golang.org/cl/13261050

Status changed to Fixed.

@bradfitz
Copy link
Contributor

bradfitz commented Sep 9, 2013

Comment 7:

*** Submitted as https://code.google.com/p/go/source/detail?r=f1754e7a7f5f ***
api: update go1.1, except and next.txt with constant values
O_SYNC changes only on linux-arm (and linux-arm-cgo), but
changes to match O_SYNC on linux-{386,amd64} and what Linux
upstream now uses.  See discussion and links on
https://golang.org/cl/13261050/
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13575045

@rsc rsc added fixed labels Sep 9, 2013
@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
4 participants
@bradfitz @rsc @robpike @gopherbot