Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: ReadResponse needs a Request #5583

Closed
taruti opened this issue May 29, 2013 · 4 comments
Closed

net/http: ReadResponse needs a Request #5583

taruti opened this issue May 29, 2013 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.2

Comments

@taruti
Copy link
Contributor

taruti commented May 29, 2013 

Currently reading a HTTP Response needs a Request. However in some cases where the exact
bits on the wire are important (faulty clients + firewalls) custom request types are
needed for things like getting header order exactly desired. 

http://play.golang.org/p/Hq8CgZcFwD
demonstrates the code.

https://golang.org/cl/9821043/ has a fix removing the need for a Request in
ReadResponse.
@bradfitz
Copy link
Contributor

Comment 1:

Labels changed: removed priority-triage.

Owner changed to @bradfitz.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 2:

Labels changed: added go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 3:

Labels changed: added feature.

@bradfitz
Copy link
Contributor

bradfitz commented Aug 9, 2013

Comment 4:

This issue was closed by revision e3dbb1a.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
4 participants
@bradfitz @taruti @rsc @gopherbot