code review 9821043: net/http: Make ReadResponse work with a nil Request par...

net/http: Make ReadResponse work with a nil Request parameter

Fixes issue 5583

[taruti, 2013-05-28 08:46:15]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
taruti@taruti.net),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-05-28 12:21:37]

On 2013/05/28 08:46:15, taruti wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com,
> mailto:taruti@taruti.net),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

Thank you for this proposal. I can see how constructing a test without a
*Request will cause a panic, but it isn't clear to me how such a condition could
be encountered. Can you please provide some sample code or a link to a
discussion.

[taruti, 2013-05-29 06:46:42]

Issue as requested: https://code.google.com/p/go/issues/detail?id=5583

[dave_cheney.net, 2013-05-29 06:47:37]

Thank you, don't forget to run hg update and add the magic works
"Fixes issue 5583." to the issue description.

On Wed, May 29, 2013 at 4:46 PM,  <taruti@taruti.net> wrote:
> Issue as requested: https://code.google.com/p/go/issues/detail?id=5583
>
>
> https://codereview.appspot.com/9821043/

[dave_cheney.net, 2013-06-11 11:55:55]

On 2013/05/29 06:47:37, dfc wrote:
> Thank you, don't forget to run hg update and add the magic works
> "Fixes issue 5583." to the issue description.
> 
> On Wed, May 29, 2013 at 4:46 PM,  <mailto:taruti@taruti.net> wrote:
> > Issue as requested: https://code.google.com/p/go/issues/detail?id=5583
> >
> >
> > https://codereview.appspot.com/9821043/

ping

[bradfitz, 2013-06-18 16:11:10]

R=bradfitz

This probably also warrants a doc update to func ReadResponse.

[taruti, 2013-07-23 06:31:11]

Hello golang-dev@googlegroups.com, dave@cheney.net, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-07-23 16:32:58]

https://codereview.appspot.com/9821043/diff/20001/src/pkg/net/http/response.go
File src/pkg/net/http/response.go (right):

https://codereview.appspot.com/9821043/diff/20001/src/pkg/net/http/response.g...
src/pkg/net/http/response.go:103: // this Response. Alternatively the Request
may be nil.
maybe just add the word "optionally" before "specifies".

Then you can say "If nil, a GET request is assumed."

https://codereview.appspot.com/9821043/diff/20001/src/pkg/net/http/response_t...
File src/pkg/net/http/response_test.go (right):

https://codereview.appspot.com/9821043/diff/20001/src/pkg/net/http/response_t...
src/pkg/net/http/response_test.go:366: "Connection": {"close"}, // TODO(rsc):
Delete?
remove comment. it's ancient and we can't change this behavior now anyway.

[bradfitz, 2013-08-09 22:06:16]

LGTM

[bradfitz, 2013-08-09 22:11:02]

*** Submitted as https://code.google.com/p/go/source/detail?r=63dcf9ca33a7 ***

net/http: Make ReadResponse work with a nil Request parameter

Fixes issue 5583

R=golang-dev, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/9821043

Committer: Brad Fitzpatrick <bradfitz@golang.org>