New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: skip TestDirJoin on Windows, even if /etc/hosts exists #5460
Labels
Milestone
Comments
TestDirJoin is meant to be skipped on windows: C:\>go test -v -run=DirJoin net/http === RUN TestDirJoin --- SKIP: TestDirJoin (0.00 seconds) fs_test.go:264: skipping test; no /etc/hosts file PASS ok net/http 0.734s C:\> How did you manage to run this test? Alex Status changed to WaitingForReply. |
I have D:\etc\hosts present in my filesystem. The test skip rule depends on os.Stat("/etc/hosts") returning an error. On windows os.Stat return is based on GetFileAttributesEx() which seems to use drive of working directory as the "/" os.Stat() may need to be fixed for windows so that path starting with "/" is not considered valid. Will prepare a patch. |
Ahhaaa!!! Good detective work. Please, send a fix. As to your other failures, I didn't get chance to look at then yet. But here is https://golang.org/issue/5263 something similar. Perhaps it is just a matter of you debugging to see why it breaks. Alex |
CL submitted https://golang.org/cl/12123043 |
This issue was closed by revision 3abaf5c. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Attachments:
The text was updated successfully, but these errors were encountered: