code review 12123043: net/http: skip TestDirJoin on Windows, even i...

net/http: skip TestDirJoin on Windows, even if /etc/hosts exists

Fixes issue 5460.

[shiv, 2013-07-30 18:10:40]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-07-31 00:06:46]

not lgtm

It is strange to single out the file name processing in a single call.
In fact, names beginning with / are accepted by the Windows kernel and
should be allowed here.

As far as I can tell, issue 5460 is about disabling a test.

[shiv, 2013-07-31 00:39:51]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-07-31 01:09:02]

Remove one of the "net/http: " prefixes in the CL description, then LGTM.


On Tue, Jul 30, 2013 at 5:39 PM, <shivakumar.gn@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/12123043/<https://codereview.appspot.com/121...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[shiv, 2013-07-31 01:24:12]

Done. PTAL.

[bradfitz, 2013-07-31 01:24:51]

LGTM

[bradfitz, 2013-07-31 01:25:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=a4702a268683 ***

net/http: skip TestDirJoin on Windows, even if /etc/hosts exists

Fixes issue 5460.

R=golang-dev, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/12123043

Committer: Brad Fitzpatrick <bradfitz@golang.org>