Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: Result interface's methods should be documented #5110

Closed
adg opened this issue Mar 22, 2013 · 5 comments
Closed

database/sql: Result interface's methods should be documented #5110

adg opened this issue Mar 22, 2013 · 5 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.2

Comments

@adg
Copy link
Contributor

adg commented Mar 22, 2013 

Says Nate Finch:

"There's no documentation about the methods on Result. There really should be...
especially LastInsertId... I don't even know what that might be for.

RowsAffected is pretty self explanatory, except for the error. When would it return an
error? Would it only be if the Exec returned an error, or can RowsAffected return an
error even if the Exec didn't? (I know it's implementation specific, but there should be
guidelines for when it is supposed to return errors)."
@bradfitz
Copy link
Contributor

Comment 1:

Labels changed: added priority-soon, documentation, go1.1maybe, removed priority-later.

Owner changed to @bradfitz.

@robpike
Copy link
Contributor

robpike commented May 18, 2013

Comment 2:

Labels changed: added go1.2maybe, removed go1.1maybe.

@bradfitz
Copy link
Contributor

Comment 3:

See https://golang.org/cl/19280046

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 4:

This issue was closed by revision 7307ffa.

Status changed to Fixed.

@adg
Copy link
Contributor Author

adg commented Nov 1, 2013

Comment 5:

This issue was closed by revision c499a78e725c.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
adg added a commit that referenced this issue May 11, 2015
@adg
[release-branch.go1.2] database/sql: document Result methods
63ff715 
««« CL 19280046 / 2ad8ac71220d
database/sql: document Result methods

Fixes #5110

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/19280046
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20650043
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
5 participants
@bradfitz @rsc @robpike @adg @gopherbot