Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1101)

Issue 19280046: code review 19280046: database/sql: document Result methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by bradfitz
Modified:
10 years, 4 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

database/sql: document Result methods Fixes issue 5110

Patch Set 1 #

Patch Set 2 : diff -r 5ed8c82778ae https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5ed8c82778ae https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r fb5224487f1b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/pkg/database/sql/sql.go View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 5 months ago (2013-10-29 22:21:03 UTC) #1
r
LGTM https://codereview.appspot.com/19280046/diff/40001/src/pkg/database/sql/sql.go File src/pkg/database/sql/sql.go (right): https://codereview.appspot.com/19280046/diff/40001/src/pkg/database/sql/sql.go#newcode1643 src/pkg/database/sql/sql.go:1643: // databases support this, and the syntax of ...
10 years, 5 months ago (2013-10-29 23:46:14 UTC) #2
bradfitz
10 years, 5 months ago (2013-10-30 00:38:46 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=2ad8ac71220d ***

database/sql: document Result methods

Fixes issue 5110

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/19280046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b