-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/cgo: stdcall import names are not undecorated and conflict with symbol versioning #4607
Labels
Milestone
Comments
IMO, we can't change symbol version delimiter to a '#', because it will break ELF based systems. just fixing cmd/cgo to emit #pragma dynimport funcname funcname@0 libname.dll on windows seems correct to me. Labels changed: added priority-later, removed priority-triage. Status changed to Accepted. |
I don't think it will break on ELF based systems, because the delimiter is handled purely by cmd/cgo and cmd/ld. Just changing cmd/cgo is not enough, because the version is parsed and stripped from dynimports for everyone including PE. Perhaps there would be a way to only do this for ELF, though. |
See here, where the delimiter is handled from cgo's dynimport output: http://code.google.com/p/go/source/browse/src/cmd/ld/go.c#509 |
This issue was closed by revision dab268f. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Attachments:
The text was updated successfully, but these errors were encountered: