Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(284)

Issue 7047043: code review 7047043: cmd/cgo: allow for stdcall decorated dynimport names

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by james4k
Modified:
11 years, 2 months ago
Reviewers:
rsc
CC:
minux1, adg, rsc, golang-dev
Visibility:
Public.

Description

cmd/cgo: allow for stdcall decorated dynimport names To allow for stdcall decorated names on Windows, two changes were needed: 1. Change the symbol versioning delimiter '@' in cgo's dynimport output to a '#', and in cmd/ld when it parses dynimports. 2. Remove the "@N" decorator from the first argument of cgo's dynimport output (PE only). Fixes issue 4607.

Patch Set 1 #

Patch Set 2 : diff -r 21096a13f14b https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r d0d76b7fb219 https://code.google.com/p/go #

Patch Set 4 : diff -r d0d76b7fb219 https://code.google.com/p/go #

Patch Set 5 : diff -r 49db9317937c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/cmd/cgo/out.go View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M src/cmd/ld/go.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
minux1
https://codereview.appspot.com/7047043/diff/2001/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): https://codereview.appspot.com/7047043/diff/2001/src/cmd/cgo/out.go#newcode221 src/cmd/cgo/out.go:221: name = name[:i] please consider using strings.Split(name, "@") then ...
11 years, 2 months ago (2013-01-03 10:49:43 UTC) #1
james4k
Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2013-01-03 20:52:24 UTC) #2
james4k
On 2013/01/03 20:52:24, james4k wrote: > Hello mailto:minux.ma@gmail.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
11 years, 2 months ago (2013-01-03 21:05:52 UTC) #3
adg
Try hg sync hg upload 7047043
11 years, 2 months ago (2013-01-06 21:41:43 UTC) #4
james4k
On 2013/01/06 21:41:43, adg wrote: > Try > > hg sync > hg upload 7047043 ...
11 years, 2 months ago (2013-01-07 04:49:54 UTC) #5
james4k
PTAL. Do you think perhaps some sort of test would be necessary? Is there an ...
11 years, 2 months ago (2013-01-07 05:07:56 UTC) #6
minux1
sorry for the long delay. please add a windows-only test to call stdcall decorated symbol ...
11 years, 2 months ago (2013-01-25 11:17:50 UTC) #7
rsc
LGTM
11 years, 2 months ago (2013-01-30 16:26:40 UTC) #8
rsc
11 years, 2 months ago (2013-01-30 16:29:38 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=d8e64f78ab02 ***

cmd/cgo: allow for stdcall decorated dynimport names

To allow for stdcall decorated names on Windows, two changes were needed:
1. Change the symbol versioning delimiter '@' in cgo's dynimport output to a
'#', and in cmd/ld when it parses dynimports.
2. Remove the "@N" decorator from the first argument of cgo's dynimport output
(PE only).

Fixes issue 4607.

R=minux.ma, adg, rsc
CC=golang-dev
https://codereview.appspot.com/7047043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b