go/token: data race on FileSet.last #4345
Labels
Milestone
Comments
Top frame of one of the stacks seems to be broken (lessstack). But the report clearly points to that ad-hoc cache: https://code.google.com/p/go/source/browse/src/pkg/go/token/position.go#379 maintained under *reader* lock: https://code.google.com/p/go/source/browse/src/pkg/go/token/position.go#392 |
If we had issue #2280 (Receiver-curried method expressions) resolved (which is currently planned for Go1.1 I think?), then I think we could use a sync.Once here efficiently, as Russ wants to make the expression "receiverVariable.Method" be no allocations. |
Do you mean that issue https://golang.org/issue/4343 ? Do I get it right that func variables will be wider (2 words), and receiver.func() will automatically convert to func()? |
|
Owner changed to @griesemer. Status changed to Accepted. |
|
Issue #4540 has been merged into this issue. |
|
Issue #4540 has been merged into this issue. |
""" The race occurs when the the test takes longer than 10 seconds, so the fixture is marked as a failure and starts the next one, which increases the likely hood of a data race on the FileSet cache. Reducing the timeout to 1 second and running `go test -race -cpu=4` triggers the race almost immediately. """ |
Proposal: https://golang.org/cl/6968044/ Owner changed to @davecheney. |
|
This issue was closed by revision 07e706f. Status changed to Fixed. |
Closed
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Revision 14791. Experimental windows race detector says: WARNING: DATA RACE Read by goroutine 15: runtime.lessstack() src/pkg/runtime/asm_amd64.s:247 +0x0 go/token.(*FileSet).Position() src/pkg/go/token/position.go:403 +0x6f go/printer.(*printer).lineFor() src/pkg/go/printer/printer.go:148 +0xa3 go/printer.(*printer).stmtList() src/pkg/go/printer/nodes.go:903 +0x1c7 go/printer.(*printer).block() src/pkg/go/printer/nodes.go:917 +0x16d go/printer.(*printer).funcBody() src/pkg/go/printer/nodes.go:1473 +0x71a go/printer.(*printer).funcDecl() src/pkg/go/printer/nodes.go:1496 +0x3e2 go/printer.(*printer).decl() src/pkg/go/printer/nodes.go:1506 +0xb5 go/printer.(*printer).file() src/pkg/go/printer/nodes.go:1548 +0x3bd go/printer.(*printer).printNode() src/pkg/go/printer/printer.go:1054 +0x71f go/printer.(*Config).fprint() src/pkg/go/printer/printer.go:1192 +0xc1 go/printer.(*Config).Fprint() src/pkg/go/printer/printer.go:1250 +0x8c go/printer.format() src/pkg/go/printer/printer_test.go:62 +0x3d4 go/printer.runcheck() src/pkg/go/printer/printer_test.go:154 +0x779 go/printer.func·005() src/pkg/go/printer/printer_test.go:172 +0x99 Previous write by goroutine 17: go/token.(*FileSet).file() src/pkg/go/token/position.go:379 +0x179 go/token.(*FileSet).Position() src/pkg/go/token/position.go:403 +0x6f go/printer.(*printer).posFor() src/pkg/go/printer/printer.go:142 +0x5b go/printer.(*printer).nextComment() src/pkg/go/printer/printer.go:121 +0x21a go/printer.(*printer).printNode() src/pkg/go/printer/printer.go:1036 +0x4ab go/printer.(*Config).fprint() src/pkg/go/printer/printer.go:1192 +0xc1 go/printer.(*Config).Fprint() src/pkg/go/printer/printer.go:1250 +0x8c go/printer.format() src/pkg/go/printer/printer_test.go:62 +0x3d4 go/printer.runcheck() src/pkg/go/printer/printer_test.go:123 +0x1b1 go/printer.func·005() src/pkg/go/printer/printer_test.go:172 +0x99 Goroutine 15 (running) created at: go/printer.check() src/pkg/go/printer/printer_test.go:174 +0x19f go/printer.TestFiles() src/pkg/go/printer/printer_test.go:209 +0x2ad testing.tRunner() src/pkg/testing/testing.go:301 +0x92 Goroutine 17 (running) created at: go/printer.check() src/pkg/go/printer/printer_test.go:174 +0x19f go/printer.TestFiles() src/pkg/go/printer/printer_test.go:209 +0x2adThe text was updated successfully, but these errors were encountered: