Issue 6968044: code review 6968044: go/token: fix data race on FileSet.last

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6968044: code review 6968044: go/token: fix data race on FileSet.last (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dave

Modified:
11 years, 4 months ago

Reviewers:

CC:
dvyukov, gri, golang-dev

Visibility:
Public.

Description

go/token: fix data race on FileSet.last Fixes issue 4345. Benchmarks are promising, benchmark old ns/op new ns/op delta BenchmarkPrint 14716391 14747131 +0.21% benchmark old ns/op new ns/op delta BenchmarkParse 8846219 8809343 -0.42% benchmark old MB/s new MB/s speedup BenchmarkParse 6.61 6.64 1.00x Also includes additional tests to improve token.FileSet coverage.

Patch Set 1 #

Patch Set 2 : diff -r e7cd0a82d669 https://code.google.com/p/go #

Patch Set 3 : diff -r e7cd0a82d669 https://code.google.com/p/go #

Patch Set 4 : diff -r e7cd0a82d669 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r e7cd0a82d669 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -8 lines)			Patch
	M	src/pkg/go/token/position.go	View	1 2 3 4	5 chunks	+10 lines, -8 lines	0 comments	Download
	M	src/pkg/go/token/position_test.go	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello dvyukov@google.com, gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2012-12-19 20:51:07 UTC) #1

gri

LGTM Thanks. A minor nitpick (addressing your concern about possible races). https://codereview.appspot.com/6968044/diff/8001/src/pkg/go/token/position.go File src/pkg/go/token/position.go (right): ...

11 years, 4 months ago (2012-12-19 21:18:47 UTC) #2

dave_cheney.net

11 years, 4 months ago (2012-12-19 21:26:56 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0c135754c93a ***

go/token: fix data race on FileSet.last

Fixes issue 4345.

Benchmarks are promising,

benchmark         old ns/op    new ns/op    delta
BenchmarkPrint     14716391     14747131   +0.21%

benchmark         old ns/op    new ns/op    delta
BenchmarkParse      8846219      8809343   -0.42%

benchmark          old MB/s     new MB/s  speedup
BenchmarkParse         6.61         6.64    1.00x

Also includes additional tests to improve token.FileSet coverage.

R=dvyukov, gri
CC=golang-dev
https://codereview.appspot.com/6968044

Expand All Messages | Collapse All Messages