Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: document ReaderFrom #3711

Closed
bradfitz opened this issue Jun 7, 2012 · 3 comments
Closed

io: document ReaderFrom #3711

bradfitz opened this issue Jun 7, 2012 · 3 comments

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jun 7, 2012

The docs on ReaderFrom are very light:

http://golang.org/pkg/io/#ReaderFrom

`
type ReaderFrom interface {
    ReadFrom(r Reader) (n int64, err error)
}
ReaderFrom is the interface that wraps the ReadFrom method.
`

But it doesn't say what the method is expected to do.

The *bytes.Buffer ReadFrom provides some clues:

http://golang.org/pkg/bytes/#Buffer.ReadFrom

... but is that the promise from a *bytes.Buffer, or of all ReadersFrom?
@rsc
Copy link
Contributor

rsc commented Jun 7, 2012

Comment 1:

Sure.

@bradfitz
Copy link
Contributor Author

bradfitz commented Aug 7, 2012

Comment 2:

http://golang.org/cl/6445083

Labels changed: removed priority-triage.

Owner changed to @bradfitz.

Status changed to Accepted.

@bradfitz
Copy link
Contributor Author

bradfitz commented Aug 7, 2012

Comment 3:

This issue was closed by revision c8423f9.

Status changed to Fixed.

@bradfitz bradfitz added the fixed label Aug 7, 2012
@bradfitz bradfitz self-assigned this Aug 7, 2012
bradfitz added a commit that referenced this issue May 11, 2015
««« backport 4e3a1967af09
io: document ReaderFrom and WriterTo

Fixes #3711

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6445083

»»»
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants