Issue 6445083: code review 6445083: io: document ReaderFrom and WriterTo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6445083: code review 6445083: io: document ReaderFrom and WriterTo (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bradfitz

Modified:
11 years, 9 months ago

Reviewers:
r

CC:
golang-dev, adg

Visibility:
Public.

Description

io: document ReaderFrom and WriterTo Fixes issue 3711

Patch Set 2 : diff -r bf1b1141ccbf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bf1b1141ccbf https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r bf1b1141ccbf https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c37d3a28f6b0 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	src/pkg/io/io.go	View	1 2 3	1 chunk	+12 lines, -0 lines	1 comment	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 9 months ago (2012-08-07 04:35:19 UTC) #1

adg

http://codereview.appspot.com/6445083/diff/4002/src/pkg/io/io.go File src/pkg/io/io.go (right): http://codereview.appspot.com/6445083/diff/4002/src/pkg/io/io.go#newcode138 src/pkg/io/io.go:138: // ReaderFrom is used by the Copy function. The ...

11 years, 9 months ago (2012-08-07 04:51:19 UTC) #2

bradfitz

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 9 months ago (2012-08-07 05:17:46 UTC) #3

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=4e3a1967af09 *** io: document ReaderFrom and WriterTo Fixes issue 3711 R=golang-dev, adg ...

11 years, 9 months ago (2012-08-07 06:10:20 UTC) #5

11 years, 9 months ago (2012-08-07 15:14:36 UTC) #6

http://codereview.appspot.com/6445083/diff/8002/src/pkg/io/io.go
File src/pkg/io/io.go (right):

http://codereview.appspot.com/6445083/diff/8002/src/pkg/io/io.go#newcode134
src/pkg/io/io.go:134: // ReadFrom reads data from r until EOF. The return value
n is the
EOF or error.

Expand All Messages | Collapse All Messages